Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2202883005: [turbofan] Unify number operation typing rules. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Unify number operation typing rules. Move all the typing rules for unary and binary number operations to the OperationTyper and use them for both the regular Typer as well as the retyper that runs as part of SimplifiedLowering. R=epertoso@chromium.org Committed: https://crrev.com/66e96fc9d7324c48da459f621c96663a29a385a1 Cr-Commit-Position: refs/heads/master@{#38283}

Patch Set 1 #

Patch Set 2 : Remove useless cementation. DCHECKs instead of defensive programming are way more useful. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+662 lines, -862 lines) Patch
M src/compiler/opcodes.h View 2 chunks +91 lines, -82 lines 0 comments Download
M src/compiler/operation-typer.h View 3 chunks +16 lines, -16 lines 0 comments Download
M src/compiler/operation-typer.cc View 5 chunks +474 lines, -56 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +27 lines, -74 lines 0 comments Download
M src/compiler/typer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/typer.cc View 11 chunks +51 lines, -463 lines 0 comments Download
M src/type-cache.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/types.h View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 5 chunks +0 lines, -169 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-03 08:29:26 UTC) #1
Benedikt Meurer
Hey Enrico, Here's the unification for the two typers; more or less mechanical change, no ...
4 years, 4 months ago (2016-08-03 08:30:27 UTC) #4
epertoso
lgtm
4 years, 4 months ago (2016-08-03 08:37:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202883005/20001
4 years, 4 months ago (2016-08-03 08:57:10 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/10160) v8_linux_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 4 months ago (2016-08-03 09:27:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202883005/20001
4 years, 4 months ago (2016-08-03 09:46:22 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-03 10:39:43 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 10:43:14 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/66e96fc9d7324c48da459f621c96663a29a385a1
Cr-Commit-Position: refs/heads/master@{#38283}

Powered by Google App Engine
This is Rietveld 408576698