src/types.h - Issue 2202883005: [turbofan] Unify number operation typing rules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/types.h

Issue 2202883005: [turbofan] Unify number operation typing rules. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Remove useless cementation. DCHECKs instead of defensive programming are way more useful. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/types.h

diff --git a/src/types.h b/src/types.h

index 435c5d899e62e0eca6583a1f1a88c643594b0679..79ed85bc6eec0df7ebb669426a3ea900557beb9e 100644

--- a/src/types.h

+++ b/src/types.h

@@ -220,7 +220,9 @@ namespace internal {

V(UniqueName, kSymbol | kInternalizedString) \

V(Name, kSymbol | kString) \

V(BooleanOrNumber, kBoolean | kNumber) \

+ V(BooleanOrNullOrNumber, kBooleanOrNumber | kNull) \

V(BooleanOrNullOrUndefined, kBoolean | kNull | kUndefined) \

+ V(NullOrNumber, kNull | kNumber) \

V(NullOrUndefined, kNull | kUndefined) \

V(Undetectable, kNullOrUndefined | kOtherUndetectable) \

V(NumberOrOddball, kNumber | kNullOrUndefined | kBoolean) \

« no previous file with comments | « src/type-cache.h ('k') | test/cctest/compiler/test-simplified-lowering.cc » ('j') | no next file with comments »