[GN] Add Core{Foundation,Services}.framework to libs in Mac build

[GN] Add Core{Foundation,Services}.framework to libs in Mac build

The gen_snapshot binary compiles on the host and needs these two frameworks on
the link line since it uses CFRunLoop and FSEvents.

R=phosek@chromium.org, zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/5c38ff418096075e59c088aad2df95c20f045969

[jamesr, 2016-08-02 00:38:22]

jamesr@chromium.org changed reviewers:
+ zra@google.com

[jamesr, 2016-08-02 00:38:22]

Some GN configurations may add these by default to the configuration for
executables, but that's slightly dangerous as linking against a framework has
runtime side effects so in the Fuchsia host configuration we don't add any
default frameworks.

[Petr Hosek, 2016-08-02 00:41:15]

phosek@chromium.org changed reviewers:
+ phosek@chromium.org

[Petr Hosek, 2016-08-02 00:41:15]

lgtm

[zra, 2016-08-02 15:41:37]

lgtm

[zra, 2016-08-02 15:41:52]

On 2016/08/02 15:41:37, zra wrote:
> lgtm

Do you need me to land this?

[abarth, 2016-08-02 15:47:26]

On 2016/08/02 at 15:41:52, zra wrote:
> On 2016/08/02 15:41:37, zra wrote:
> > lgtm
> 
> Do you need me to land this?

I think he does.

[zra, 2016-08-02 16:19:58]

Description was changed from

==========
[GN] Add Core{Foundation,Services}.framework to libs in Mac build

The gen_snapshot binary compiles on the host and needs these two frameworks on
the link line since it uses CFRunLoop and FSEvents.
==========

to

==========
[GN] Add Core{Foundation,Services}.framework to libs in Mac build

The gen_snapshot binary compiles on the host and needs these two frameworks on
the link line since it uses CFRunLoop and FSEvents.

R=phosek@chromium.org, zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5c38ff418096075e59c088aad2df95c20f045969
==========

[zra, 2016-08-02 16:20:00]

Committed patchset #1 (id:1) manually as
5c38ff418096075e59c088aad2df95c20f045969 (presubmit successful).