runtime/bin/BUILD.gn - Issue 2202883002: [GN] Add Core{Foundation,Services}.framework to libs in Mac build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/BUILD.gn

Issue 2202883002: [GN] Add Core{Foundation,Services}.framework to libs in Mac build (Closed) Base URL: https://chromium.googlesource.com/external/github.com/dart-lang/sdk/@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/BUILD.gn

diff --git a/runtime/bin/BUILD.gn b/runtime/bin/BUILD.gn

index 2e92fe37b968bc3026492dd109dad00f3d5f1e77..c55e23ba3bbf7b3e8a1cc9b327f7f114e73ee017 100644

--- a/runtime/bin/BUILD.gn

+++ b/runtime/bin/BUILD.gn

@@ -255,6 +255,13 @@ executable("gen_snapshot") {

include_dirs = [

"..",

]

+ if (is_mac) {

+ libs = [

+ "CoreFoundation.framework",

+ "CoreServices.framework"

+ ]

+ }

}

# A source set for the implementation of 'dart:io' library

« no previous file with comments | « no previous file | no next file » | no next file with comments »