Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Side by Side Diff: base/android/apk_assets.cc

Issue 2202793002: base: Remove unneeded RegisterNatives() calls on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@jnireg2
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/android/apk_assets.h ('k') | base/android/base_jni_registrar.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <jni.h> 5 #include <jni.h>
6 6
7 #include "base/android/apk_assets.h" 7 #include "base/android/apk_assets.h"
8 8
9 #include "base/android/context_utils.h" 9 #include "base/android/context_utils.h"
10 #include "base/android/jni_array.h" 10 #include "base/android/jni_array.h"
11 #include "base/android/jni_string.h" 11 #include "base/android/jni_string.h"
12 #include "base/android/scoped_java_ref.h" 12 #include "base/android/scoped_java_ref.h"
13 #include "jni/ApkAssets_jni.h" 13 #include "jni/ApkAssets_jni.h"
14 14
15 namespace base { 15 namespace base {
16 namespace android { 16 namespace android {
17 17
18 bool RegisterApkAssets(JNIEnv* env) {
19 return RegisterNativesImpl(env);
20 }
21
22 int OpenApkAsset(const std::string& file_path, 18 int OpenApkAsset(const std::string& file_path,
23 base::MemoryMappedFile::Region* region) { 19 base::MemoryMappedFile::Region* region) {
24 // The AAssetManager API of the NDK is does not expose a method for accessing 20 // The AAssetManager API of the NDK is does not expose a method for accessing
25 // raw resources :(. 21 // raw resources :(.
26 JNIEnv* env = base::android::AttachCurrentThread(); 22 JNIEnv* env = base::android::AttachCurrentThread();
27 ScopedJavaLocalRef<jlongArray> jarr = Java_ApkAssets_open( 23 ScopedJavaLocalRef<jlongArray> jarr = Java_ApkAssets_open(
28 env, 24 env,
29 base::android::GetApplicationContext(), 25 base::android::GetApplicationContext(),
30 base::android::ConvertUTF8ToJavaString(env, file_path).obj()); 26 base::android::ConvertUTF8ToJavaString(env, file_path).obj());
31 std::vector<jlong> results; 27 std::vector<jlong> results;
(...skipping 11 matching lines...) Expand all
43 base::MemoryMappedFile::Region::kWholeFile; 39 base::MemoryMappedFile::Region::kWholeFile;
44 int asset_fd = OpenApkAsset(file_path, &region); 40 int asset_fd = OpenApkAsset(file_path, &region);
45 if (asset_fd != -1) { 41 if (asset_fd != -1) {
46 base::GlobalDescriptors::GetInstance()->Set(key, asset_fd, region); 42 base::GlobalDescriptors::GetInstance()->Set(key, asset_fd, region);
47 } 43 }
48 return asset_fd != -1; 44 return asset_fd != -1;
49 } 45 }
50 46
51 } // namespace android 47 } // namespace android
52 } // namespace base 48 } // namespace base
OLDNEW
« no previous file with comments | « base/android/apk_assets.h ('k') | base/android/base_jni_registrar.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698