AOT: Faster invocation of callback fields.

AOT: Faster invocation of callback fields.

In the JIT we dynamically create stubs for implicit closure invocation of fields.

For AOT we only used to do this for the .call invocations (explicit closure calls).
Other fields invocations would go through the slower runtime call.

This CL adds invocation stubs in AOT mode for all fields that have a function type
as type annotation (likely callback fields) and avoid the overhead of runtime calls.

The invocation stubs are cached at receiver classes. Therefore, they are added to
all subclasses of a class that defines a callback field.

This speeds up Flutter's layout_bench on a Nexus 4 by 6.8%.

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/08a96e13b71797a8cabeb00552b84e853cb3b9cb

[Florian Schneider, 2016-08-01 21:51:04]

Description was changed from

==========
AOT: Faster invocation of callback fields.

In the JIT we dynamically create stubs for implicit closure invocation of
fields.

For AOT we only used to do this for the .call invocations (explicit closure
calls).
Other fields invocations would go through the slower runtime call.

This CL adds invocation stubs in AOT mode for all fields that have a function
type
as type annotation (likely callback fields) and avoid the overhead of runtime
calls.

The invocation stubs are cached at receiver classes. Therefore, they are added
to
all subclasses of a class that defines a callback field.
==========

to

==========
AOT: Faster invocation of callback fields.

In the JIT we dynamically create stubs for implicit closure invocation of
fields.

For AOT we only used to do this for the .call invocations (explicit closure
calls).
Other fields invocations would go through the slower runtime call.

This CL adds invocation stubs in AOT mode for all fields that have a function
type
as type annotation (likely callback fields) and avoid the overhead of runtime
calls.

The invocation stubs are cached at receiver classes. Therefore, they are added
to
all subclasses of a class that defines a callback field.

This speeds up Flutter's layout_bench by 6.8%.
==========

[Florian Schneider, 2016-08-01 21:51:18]

Description was changed from

==========
AOT: Faster invocation of callback fields.

In the JIT we dynamically create stubs for implicit closure invocation of
fields.

For AOT we only used to do this for the .call invocations (explicit closure
calls).
Other fields invocations would go through the slower runtime call.

This CL adds invocation stubs in AOT mode for all fields that have a function
type
as type annotation (likely callback fields) and avoid the overhead of runtime
calls.

The invocation stubs are cached at receiver classes. Therefore, they are added
to
all subclasses of a class that defines a callback field.

This speeds up Flutter's layout_bench by 6.8%.
==========

to

==========
AOT: Faster invocation of callback fields.

In the JIT we dynamically create stubs for implicit closure invocation of
fields.

For AOT we only used to do this for the .call invocations (explicit closure
calls).
Other fields invocations would go through the slower runtime call.

This CL adds invocation stubs in AOT mode for all fields that have a function
type
as type annotation (likely callback fields) and avoid the overhead of runtime
calls.

The invocation stubs are cached at receiver classes. Therefore, they are added
to
all subclasses of a class that defines a callback field.

This speeds up Flutter's layout_benchon a Nexus 4 by 6.8%.
==========

[Florian Schneider, 2016-08-01 21:51:27]

Description was changed from

==========
AOT: Faster invocation of callback fields.

In the JIT we dynamically create stubs for implicit closure invocation of
fields.

For AOT we only used to do this for the .call invocations (explicit closure
calls).
Other fields invocations would go through the slower runtime call.

This CL adds invocation stubs in AOT mode for all fields that have a function
type
as type annotation (likely callback fields) and avoid the overhead of runtime
calls.

The invocation stubs are cached at receiver classes. Therefore, they are added
to
all subclasses of a class that defines a callback field.

This speeds up Flutter's layout_benchon a Nexus 4 by 6.8%.
==========

to

==========
AOT: Faster invocation of callback fields.

In the JIT we dynamically create stubs for implicit closure invocation of
fields.

For AOT we only used to do this for the .call invocations (explicit closure
calls).
Other fields invocations would go through the slower runtime call.

This CL adds invocation stubs in AOT mode for all fields that have a function
type
as type annotation (likely callback fields) and avoid the overhead of runtime
calls.

The invocation stubs are cached at receiver classes. Therefore, they are added
to
all subclasses of a class that defines a callback field.

This speeds up Flutter's layout_bench on a Nexus 4 by 6.8%.
==========

[Florian Schneider, 2016-08-01 21:51:39]

fschneider@google.com changed reviewers:
+ rmacnak@google.com

[Florian Schneider, 2016-08-01 22:30:15]

===
µs per iteration before

1056.6
1057.3
1054.4
1078.4
1058.4
1052.9
1059.1
1055.5
1069.1
1055.8

===
µs per iteration after

981.6
1007.3
1001.2
992.3
1004.0
981.7
1001.4
998.9
974.8
974.7

[rmacnak, 2016-08-01 23:41:08]

lgtm w/c

https://codereview.chromium.org/2202773002/diff/1/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/2202773002/diff/1/runtime/vm/precompiler.cc#n...
runtime/vm/precompiler.cc:558: OS::Print("Found callback field %s\n",
field_name.ToCString());
THR_Print

https://codereview.chromium.org/2202773002/diff/1/runtime/vm/precompiler.cc#n...
runtime/vm/precompiler.cc:563: if (!T->cha()->ConcreteSubclasses(cls, &cids))
return;
continue in the class loop

Without labeled break/continue, probably easier to place the rest of the loop
under an if.

https://codereview.chromium.org/2202773002/diff/1/runtime/vm/precompiler.cc#n...
runtime/vm/precompiler.cc:574: OS::Print("Added invoke-field-dispatcher for %s
to %s\n",
THR_Print

[Florian Schneider, 2016-08-01 23:57:00]

https://codereview.chromium.org/2202773002/diff/1/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/2202773002/diff/1/runtime/vm/precompiler.cc#n...
runtime/vm/precompiler.cc:558: OS::Print("Found callback field %s\n",
field_name.ToCString());
On 2016/08/01 23:41:08, rmacnak wrote:
> THR_Print

Done.

https://codereview.chromium.org/2202773002/diff/1/runtime/vm/precompiler.cc#n...
runtime/vm/precompiler.cc:563: if (!T->cha()->ConcreteSubclasses(cls, &cids))
return;
On 2016/08/01 23:41:08, rmacnak wrote:
> continue in the class loop
> 
> Without labeled break/continue, probably easier to place the rest of the loop
> under an if.

Yes, done.

https://codereview.chromium.org/2202773002/diff/1/runtime/vm/precompiler.cc#n...
runtime/vm/precompiler.cc:574: OS::Print("Added invoke-field-dispatcher for %s
to %s\n",
On 2016/08/01 23:41:08, rmacnak wrote:
> THR_Print

Done.

[Florian Schneider, 2016-08-02 00:16:59]

Description was changed from

==========
AOT: Faster invocation of callback fields.

In the JIT we dynamically create stubs for implicit closure invocation of
fields.

For AOT we only used to do this for the .call invocations (explicit closure
calls).
Other fields invocations would go through the slower runtime call.

This CL adds invocation stubs in AOT mode for all fields that have a function
type
as type annotation (likely callback fields) and avoid the overhead of runtime
calls.

The invocation stubs are cached at receiver classes. Therefore, they are added
to
all subclasses of a class that defines a callback field.

This speeds up Flutter's layout_bench on a Nexus 4 by 6.8%.
==========

to

==========
AOT: Faster invocation of callback fields.

In the JIT we dynamically create stubs for implicit closure invocation of
fields.

For AOT we only used to do this for the .call invocations (explicit closure
calls).
Other fields invocations would go through the slower runtime call.

This CL adds invocation stubs in AOT mode for all fields that have a function
type
as type annotation (likely callback fields) and avoid the overhead of runtime
calls.

The invocation stubs are cached at receiver classes. Therefore, they are added
to
all subclasses of a class that defines a callback field.

This speeds up Flutter's layout_bench on a Nexus 4 by 6.8%.

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/08a96e13b71797a8cabeb00552b84e853cb3b9cb
==========

[Florian Schneider, 2016-08-02 00:17:01]

Committed patchset #2 (id:20001) manually as
08a96e13b71797a8cabeb00552b84e853cb3b9cb (presubmit successful).