AOT: Faster invocation of callback fields.

runtime/vm/precompiler.cc

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/precompiler.h"
 
 #include "vm/aot_optimizer.h"
 #include "vm/assembler.h"
 #include "vm/ast_printer.h"
 #include "vm/branch_optimizer.h"
@@ skipping 498 matching lines @@
 
     while (pending_functions_.Length() > 0) {
       function ^= pending_functions_.RemoveLast();
       ProcessFunction(function);
     }
 
     CheckForNewDynamicFunctions();
     if (!changed_) {
       TraceConstFunctions();
     }
+    CollectCallbackFields();
+  }
+}
+
+
+void Precompiler::CollectCallbackFields() {
+  Library& lib = Library::Handle(Z);
+  Class& cls = Class::Handle(Z);
+  Class& subcls = Class::Handle(Z);
+  Array& fields = Array::Handle(Z);
+  Field& field = Field::Handle(Z);
+  Function& function = Function::Handle(Z);
+  Function& dispatcher = Function::Handle(Z);
+  Array& args_desc = Array::Handle(Z);
+  AbstractType& field_type = AbstractType::Handle(Z);
+  String& field_name = String::Handle(Z);
+  GrowableArray<intptr_t> cids;
+
+  for (intptr_t i = 0; i < libraries_.Length(); i++) {
+    lib ^= libraries_.At(i);
+    ClassDictionaryIterator it(lib, ClassDictionaryIterator::kIteratePrivate);
+    while (it.HasNext()) {
+      cls = it.GetNextClass();
+
+      if (!cls.is_allocated()) continue;
+
+      fields = cls.fields();
+      for (intptr_t k = 0; k < fields.Length(); k++) {
+        field ^= fields.At(k);
+        if (field.is_static()) continue;
+        field_type = field.type();
+        if (!field_type.IsFunctionType()) continue;
+        field_name = field.name();
+        if (!IsSent(field_name)) continue;
+        // Create arguments descriptor with fixed parameters from
+        // signature of field_type.
+        function = Type::Cast(field_type).signature();
+        if (function.HasOptionalParameters()) continue;
+        if (FLAG_trace_precompiler) {
+          OS::Print("Found callback field %s\n", field_name.ToCString());

[rmacnak, 2016/08/01 23:41:08]

THR_Print

[Florian Schneider, 2016/08/01 23:57:00]

Done.

+        }
+        args_desc =
+            ArgumentsDescriptor::New(function.num_fixed_parameters());
+        cids.Clear();
+        if (!T->cha()->ConcreteSubclasses(cls, &cids)) return;

[rmacnak, 2016/08/01 23:41:08]

continue in the class loop

Without labeled break/continue, probably easier to place the rest of the loop
under an if.

[Florian Schneider, 2016/08/01 23:57:00]

Yes, done.

+        for (intptr_t j = 0; j < cids.length(); ++j) {
+          subcls ^= I->class_table()->At(cids[j]);
+          if (subcls.is_allocated()) {
+            // Add dispatcher to cls.
+            dispatcher = subcls.GetInvocationDispatcher(
+                field_name,
+                args_desc,
+                RawFunction::kInvokeFieldDispatcher,
+                /* create_if_absent = */ true);
+            if (FLAG_trace_precompiler) {
+              OS::Print("Added invoke-field-dispatcher for %s to %s\n",

[rmacnak, 2016/08/01 23:41:08]

THR_Print

[Florian Schneider, 2016/08/01 23:57:00]

Done.

+                        field_name.ToCString(), subcls.ToCString());
+            }
+            AddFunction(dispatcher);
+          }
+        }
+      }
+    }
   }
 }
 
 
 void Precompiler::ProcessFunction(const Function& function) {
   if (!function.HasCode()) {
     function_count_++;
 
     if (FLAG_trace_precompiler) {
       THR_Print("Precompiling %" Pd " %s (%s, %s)\n",
@@ skipping 2357 matching lines @@
       CompilationPipeline::New(thread->zone(), function);
 
   ASSERT(FLAG_precompiled_mode);
   const bool optimized = function.IsOptimizable();  // False for natives.
   return PrecompileFunctionHelper(pipeline, function, optimized);
 }
 
 #endif  // DART_PRECOMPILER
 
 }  // namespace dart