Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 2202763002: Fix SkJpegCodec::onSkipScanlines when TURBO_HAS_SKIP is not defined (Closed)

Created:
4 years, 4 months ago by msarett
Modified:
4 years, 4 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix SkJpegCodec::onSkipScanlines when TURBO_HAS_SKIP is not defined I think I just broke this in: https://codereview.chromium.org/2174493002/ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202763002 Committed: https://skia.googlesource.com/skia/+/6fd4c05aaf6f409b8c97ec97eb1041c0dd6a15b4

Patch Set 1 #

Patch Set 2 : Use NO_SIMD bot for testing #

Patch Set 3 : Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M src/codec/SkJpegCodec.h View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M src/codec/SkJpegCodec.cpp View 2 chunks +9 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (10 generated)
msarett
I think we need a bot testing this, otherwise it will keep breaking. I'll follow-up.
4 years, 4 months ago (2016-08-01 21:05:33 UTC) #5
mtklein
lgtm
4 years, 4 months ago (2016-08-01 22:07:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202763002/40001
4 years, 4 months ago (2016-08-01 22:07:08 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 22:08:06 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/6fd4c05aaf6f409b8c97ec97eb1041c0dd6a15b4

Powered by Google App Engine
This is Rietveld 408576698