Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2202753002: [arc-intents] Properly qualify API-generated page transitions. (Closed)

Created:
4 years, 4 months ago by Ben Kwa
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, sadrul, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[arc-intents] Properly qualify API-generated page transitions. Unqualified page transitions are treated as link-clicks, which can get sent to android via the arc intent mechanism. This can result in infinite-looping if the URL that is being opened originated from android in the first place. Marking this as an API-generated page transition ensures that the arc intent code does not forward this URL back to android. BUG=632360 Review-Url: https://codereview.chromium.org/2189063002 Cr-Commit-Position: refs/heads/master@{#408775} (cherry picked from commit b7af62bdaac59bc72d4a87581243a2ce634d0918) Committed: https://chromium.googlesource.com/chromium/src/+/97ec68299a62dd2cb000639e7e990235b513eadc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M ash/shell/shell_delegate_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/sysui/shell_delegate_mus.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/sysui/shell_delegate_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_shell_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_shell_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M components/arc/intent_helper/arc_intent_helper_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Ben Kwa
4 years, 4 months ago (2016-08-01 20:55:30 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
97ec68299a62dd2cb000639e7e990235b513eadc.

Powered by Google App Engine
This is Rietveld 408576698