Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2202743002: Settings Menu: Apply actionable attribute to Advanced expand trigger. (Closed)

Created:
4 years, 4 months ago by tommycli
Modified:
4 years, 4 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings Menu: Apply actionable attribute to Advanced expand trigger. BUG=633102 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/79c2c90d062fc2dfeabf86b8161c5d7b16353876 Cr-Commit-Position: refs/heads/master@{#409075}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/resources/settings/settings_menu/settings_menu.html View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
tommycli
dbeam: PTAL, thanks!
4 years, 4 months ago (2016-08-01 20:34:00 UTC) #3
Dan Beam
lgtm
4 years, 4 months ago (2016-08-01 20:42:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202743002/1
4 years, 4 months ago (2016-08-01 20:56:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 22:34:52 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 22:41:06 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/79c2c90d062fc2dfeabf86b8161c5d7b16353876
Cr-Commit-Position: refs/heads/master@{#409075}

Powered by Google App Engine
This is Rietveld 408576698