Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(857)

Side by Side Diff: chrome/browser/resources/settings/settings_menu/settings_menu.html

Issue 2202743002: Settings Menu: Apply actionable attribute to Advanced expand trigger. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 1 <link rel="import" href="chrome://resources/cr_elements/icons.html">
2 <link rel="import" href="chrome://resources/html/assert.html"> 2 <link rel="import" href="chrome://resources/html/assert.html">
3 <link rel="import" href="chrome://resources/html/polymer.html"> 3 <link rel="import" href="chrome://resources/html/polymer.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-menu.h tml"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-menu.h tml">
6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-submen u.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-submen u.html">
7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-ripple/paper-ripp le.html"> 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-ripple/paper-ripp le.html">
8 <link rel="import" href="/icons.html"> 8 <link rel="import" href="/icons.html">
9 <link rel="import" href="/route.html"> 9 <link rel="import" href="/route.html">
10 <link rel="import" href="/settings_shared_css.html"> 10 <link rel="import" href="/settings_shared_css.html">
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 $i18n{defaultBrowser} 124 $i18n{defaultBrowser}
125 </div> 125 </div>
126 </if> 126 </if>
127 <div data-path="/onStartup" on-tap="openPage_" 127 <div data-path="/onStartup" on-tap="openPage_"
128 hidden="[[!pageVisibility.onStartup]]"> 128 hidden="[[!pageVisibility.onStartup]]">
129 <iron-icon icon="settings:power-settings-new"></iron-icon> 129 <iron-icon icon="settings:power-settings-new"></iron-icon>
130 $i18n{onStartup} 130 $i18n{onStartup}
131 </div> 131 </div>
132 </paper-menu> 132 </paper-menu>
133 </div> 133 </div>
134 <paper-submenu class="page-menu" id="advancedPage" 134 <paper-submenu class="page-menu" id="advancedPage" actionable
135 opened="{{advancedOpened_}}" hidden="[[!pageVisibility.advancedSetting s]]"> 135 opened="{{advancedOpened_}}"
136 hidden="[[!pageVisibility.advancedSettings]]">
136 <div class="menu-trigger"> 137 <div class="menu-trigger">
137 <span>$i18n{advancedPageTitle}</span> 138 <span>$i18n{advancedPageTitle}</span>
138 <iron-icon icon="[[arrowState_(advancedOpened_)]]"></iron-icon> 139 <iron-icon icon="[[arrowState_(advancedOpened_)]]"></iron-icon>
139 </div> 140 </div>
140 <paper-menu attr-for-selected="data-path" class="menu-content" 141 <paper-menu attr-for-selected="data-path" class="menu-content"
141 id="advancedMenu" selected="[[currentRoute.path]]"> 142 id="advancedMenu" selected="[[currentRoute.path]]">
142 <if expr="chromeos"> 143 <if expr="chromeos">
143 <div data-path="/dateTime" on-tap="openPage_"> 144 <div data-path="/dateTime" on-tap="openPage_">
144 <iron-icon icon="settings:access-time"></iron-icon> 145 <iron-icon icon="settings:access-time"></iron-icon>
145 $i18n{dateTimePageTitle} 146 $i18n{dateTimePageTitle}
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 <div class="separator"></div> 193 <div class="separator"></div>
193 <paper-submenu class="page-menu"> 194 <paper-submenu class="page-menu">
194 <div class="menu-trigger" on-tap="openPage_" data-path="/help"> 195 <div class="menu-trigger" on-tap="openPage_" data-path="/help">
195 $i18n{aboutPageTitle} 196 $i18n{aboutPageTitle}
196 </div> 197 </div>
197 </paper-submenu> 198 </paper-submenu>
198 </paper-menu> 199 </paper-menu>
199 </template> 200 </template>
200 <script src="settings_menu.js"></script> 201 <script src="settings_menu.js"></script>
201 </dom-module> 202 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698