Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 2202733004: Renaming Linux security key auth handler (Closed)

Created:
4 years, 4 months ago by joedow
Modified:
4 years, 4 months ago
Reviewers:
Sergey Ulanov, joedow1
CC:
chromium-reviews, Dirk Pranke, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renaming Linux security key auth handler This change renames the linux security key auth handler class and tests so that it will apply to OSX as well. I had originally thought that I would use the same IPC classes for Windows and Mac, but I think reusing the Linux classes makes more sense. This change is purely a rename. Subsequent CLs will start adapting the classes for the OSX requirements. BUG=633025 Committed: https://crrev.com/a933972b5b5e52a49fd4c0e95741e83c661f1f80 Cr-Commit-Position: refs/heads/master@{#409417}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -653 lines) Patch
M remoting/host/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/security_key/security_key_auth_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
D remoting/host/security_key/security_key_auth_handler_android.cc View 1 chunk +0 lines, -16 lines 0 comments Download
D remoting/host/security_key/security_key_auth_handler_linux.cc View 1 chunk +0 lines, -306 lines 0 comments Download
D remoting/host/security_key/security_key_auth_handler_linux_unittest.cc View 1 chunk +0 lines, -267 lines 0 comments Download
D remoting/host/security_key/security_key_auth_handler_mac.cc View 1 chunk +0 lines, -18 lines 0 comments Download
A + remoting/host/security_key/security_key_auth_handler_posix.cc View 11 chunks +29 lines, -29 lines 0 comments Download
A + remoting/host/security_key/security_key_auth_handler_posix_unittest.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M remoting/remoting_host_srcs.gypi View 1 chunk +1 line, -3 lines 0 comments Download
M remoting/remoting_test.gypi View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (11 generated)
joedow
PTAL!
4 years, 4 months ago (2016-08-01 23:37:57 UTC) #8
joedow
Ping!
4 years, 4 months ago (2016-08-02 20:04:23 UTC) #11
Sergey Ulanov
lgtm
4 years, 4 months ago (2016-08-02 21:22:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202733004/1
4 years, 4 months ago (2016-08-02 23:00:59 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 01:23:05 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 01:26:18 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a933972b5b5e52a49fd4c0e95741e83c661f1f80
Cr-Commit-Position: refs/heads/master@{#409417}

Powered by Google App Engine
This is Rietveld 408576698