Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2195273002: Renaming Linux security key auth handler (Closed)

Created:
4 years, 4 months ago by joedow
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renaming Linux security key auth handler This change renames the linux security key auth handler class and tests so that it will apply to OSX as well. I had originally thought that I would use the same IPC classes for Windows and Mac, but I think reusing the Linux classes makes more sense. This change is purely a rename. Subsequent CLs will start adapting the classes for the OSX requirements. BUG=633025

Patch Set 1 #

Patch Set 2 : Fixing a build issue #

Patch Set 3 : Merging with ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -653 lines) Patch
M remoting/host/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/security_key/security_key_auth_handler.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
D remoting/host/security_key/security_key_auth_handler_android.cc View 1 chunk +0 lines, -16 lines 0 comments Download
D remoting/host/security_key/security_key_auth_handler_linux.cc View 1 chunk +0 lines, -306 lines 0 comments Download
D remoting/host/security_key/security_key_auth_handler_linux_unittest.cc View 1 chunk +0 lines, -267 lines 0 comments Download
D remoting/host/security_key/security_key_auth_handler_mac.cc View 1 chunk +0 lines, -18 lines 0 comments Download
A + remoting/host/security_key/security_key_auth_handler_posix.cc View 11 chunks +29 lines, -29 lines 0 comments Download
A + remoting/host/security_key/security_key_auth_handler_posix_unittest.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M remoting/remoting_host_srcs.gypi View 1 chunk +1 line, -3 lines 0 comments Download
M remoting/remoting_test.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2195273002 Patch 1

Messages

Total messages: 12 (12 generated)
joedow
The CQ bit was checked by joedow@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-01 03:29:19 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195273002/1
4 years, 4 months ago (2016-08-01 03:29:26 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-01 03:57:26 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/243125)
4 years, 4 months ago (2016-08-01 03:57:27 UTC) #4
joedow
The CQ bit was checked by joedow@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-01 22:06:33 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195273002/20001
4 years, 4 months ago (2016-08-01 22:06:58 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-01 22:09:57 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/105198) chromeos_daisy_chromium_compile_only_ng on ...
4 years, 4 months ago (2016-08-01 22:09:59 UTC) #8
joedow
The CQ bit was checked by joedow@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-01 22:16:29 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195273002/40001
4 years, 4 months ago (2016-08-01 22:16:55 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-01 22:20:25 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 22:20:25 UTC) #12 
Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698