Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 2202713005: Revert of exo: Convert initial bounds to screen coordinates (Closed)

Created:
4 years, 4 months ago by Dominik Laskowski
Modified:
4 years, 4 months ago
Reviewers:
reveman, oshima
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of exo: Convert initial bounds to screen coordinates (patchset #1 id:1 of https://codereview.chromium.org/2175373003/ ) Reason for revert: Breaks overview mode for ARC windows. Original issue's description: > exo: Convert initial bounds to screen coordinates > > Since the initial bounds of a ShellSurface were relative to the root > window, pop-up windows (e.g. context menus in weston-terminal) whose > parents are on a secondary display would appear on the primary display. > > BUG=631136 > TEST=Drag weston-terminal to secondary display and right-click. > TEST=ARC apps can still be dragged and maximized. > > Committed: https://crrev.com/9ae6cfed8f37fe4438e00126995dc863c03dd294 > Cr-Commit-Position: refs/heads/master@{#408535} TBR=reveman@chromium.org,oshima@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=631136 Committed: https://crrev.com/ee97bde5e7f990c2714e3486b60b9a62c1871c92 Cr-Commit-Position: refs/heads/master@{#409399}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M components/exo/display.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M components/exo/shell_surface.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (8 generated)
Dominik Laskowski
Created Revert of exo: Convert initial bounds to screen coordinates
4 years, 4 months ago (2016-08-02 18:17:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202713005/1
4 years, 4 months ago (2016-08-02 18:18:05 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-02 18:18:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202713005/1
4 years, 4 months ago (2016-08-02 19:50:28 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-02 19:50:30 UTC) #9
oshima
lgtm lgtm
4 years, 4 months ago (2016-08-02 20:23:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202713005/1
4 years, 4 months ago (2016-08-02 20:23:24 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/134161) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 4 months ago (2016-08-02 21:30:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202713005/1
4 years, 4 months ago (2016-08-02 23:42:45 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 00:29:07 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 00:30:30 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee97bde5e7f990c2714e3486b60b9a62c1871c92
Cr-Commit-Position: refs/heads/master@{#409399}

Powered by Google App Engine
This is Rietveld 408576698