Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Side by Side Diff: components/exo/display.cc

Issue 2202713005: Revert of exo: Convert initial bounds to screen coordinates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/exo/shell_surface.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/exo/display.h" 5 #include "components/exo/display.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <utility> 8 #include <utility>
9 9
10 #include "ash/common/shell_window_ids.h" 10 #include "ash/common/shell_window_ids.h"
11 #include "base/command_line.h" 11 #include "base/command_line.h"
12 #include "base/memory/ptr_util.h" 12 #include "base/memory/ptr_util.h"
13 #include "base/trace_event/trace_event.h" 13 #include "base/trace_event/trace_event.h"
14 #include "base/trace_event/trace_event_argument.h" 14 #include "base/trace_event/trace_event_argument.h"
15 #include "components/exo/notification_surface.h" 15 #include "components/exo/notification_surface.h"
16 #include "components/exo/notification_surface_manager.h" 16 #include "components/exo/notification_surface_manager.h"
17 #include "components/exo/shared_memory.h" 17 #include "components/exo/shared_memory.h"
18 #include "components/exo/shell_surface.h" 18 #include "components/exo/shell_surface.h"
19 #include "components/exo/sub_surface.h" 19 #include "components/exo/sub_surface.h"
20 #include "components/exo/surface.h" 20 #include "components/exo/surface.h"
21 #include "ui/views/widget/widget.h" 21 #include "ui/views/widget/widget.h"
22 #include "ui/wm/core/coordinate_conversion.h"
23 22
24 #if defined(USE_OZONE) 23 #if defined(USE_OZONE)
25 #include <GLES2/gl2extchromium.h> 24 #include <GLES2/gl2extchromium.h>
26 #include "components/exo/buffer.h" 25 #include "components/exo/buffer.h"
27 #include "gpu/command_buffer/client/gpu_memory_buffer_manager.h" 26 #include "gpu/command_buffer/client/gpu_memory_buffer_manager.h"
28 #include "third_party/khronos/GLES2/gl2.h" 27 #include "third_party/khronos/GLES2/gl2.h"
29 #include "third_party/khronos/GLES2/gl2ext.h" 28 #include "third_party/khronos/GLES2/gl2ext.h"
30 #include "ui/aura/env.h" 29 #include "ui/aura/env.h"
31 #endif 30 #endif
32 31
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 DLOG(ERROR) << "Parent is contained within surface's hierarchy"; 128 DLOG(ERROR) << "Parent is contained within surface's hierarchy";
130 return nullptr; 129 return nullptr;
131 } 130 }
132 131
133 if (surface->HasSurfaceDelegate()) { 132 if (surface->HasSurfaceDelegate()) {
134 DLOG(ERROR) << "Surface has already been assigned a role"; 133 DLOG(ERROR) << "Surface has already been assigned a role";
135 return nullptr; 134 return nullptr;
136 } 135 }
137 136
138 // Determine the initial bounds for popup. |position| is relative to the 137 // Determine the initial bounds for popup. |position| is relative to the
139 // parent's main surface origin and initial bounds are in screen coordinates. 138 // parent's main surface origin and initial bounds are relative to the
140 gfx::Point origin = position; 139 // container origin.
141 wm::ConvertPointToScreen( 140 gfx::Rect initial_bounds(position, gfx::Size(1, 1));
141 aura::Window::ConvertRectToTarget(
142 ShellSurface::GetMainSurface(parent->GetWidget()->GetNativeWindow()) 142 ShellSurface::GetMainSurface(parent->GetWidget()->GetNativeWindow())
143 ->window(), 143 ->window(),
144 &origin); 144 parent->GetWidget()->GetNativeWindow()->parent(), &initial_bounds);
145 gfx::Rect initial_bounds(origin, gfx::Size(1, 1));
146 145
147 return base::WrapUnique( 146 return base::WrapUnique(
148 new ShellSurface(surface, parent, initial_bounds, false /* activatable */, 147 new ShellSurface(surface, parent, initial_bounds, false /* activatable */,
149 ash::kShellWindowId_DefaultContainer)); 148 ash::kShellWindowId_DefaultContainer));
150 } 149 }
151 150
152 std::unique_ptr<ShellSurface> Display::CreateRemoteShellSurface( 151 std::unique_ptr<ShellSurface> Display::CreateRemoteShellSurface(
153 Surface* surface, 152 Surface* surface,
154 int container) { 153 int container) {
155 TRACE_EVENT2("exo", "Display::CreateRemoteShellSurface", "surface", 154 TRACE_EVENT2("exo", "Display::CreateRemoteShellSurface", "surface",
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 notification_surface_manager_->GetSurface(notification_id)) { 191 notification_surface_manager_->GetSurface(notification_id)) {
193 DLOG(ERROR) << "Invalid notification id, id=" << notification_id; 192 DLOG(ERROR) << "Invalid notification id, id=" << notification_id;
194 return nullptr; 193 return nullptr;
195 } 194 }
196 195
197 return base::MakeUnique<NotificationSurface>(notification_surface_manager_, 196 return base::MakeUnique<NotificationSurface>(notification_surface_manager_,
198 surface, notification_id); 197 surface, notification_id);
199 } 198 }
200 199
201 } // namespace exo 200 } // namespace exo
OLDNEW
« no previous file with comments | « no previous file | components/exo/shell_surface.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698