Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: chromeos/network/network_device_handler_impl.h

Issue 2202693005: Don't set MAC address randomization when unsupported (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use weak ptr Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chromeos/network/network_device_handler_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/network_device_handler_impl.h
diff --git a/chromeos/network/network_device_handler_impl.h b/chromeos/network/network_device_handler_impl.h
index 6020a23c5bad828159324d5544b61de4516670b9..1f1b95779be8bfa0596e719352b933a55699de3d 100644
--- a/chromeos/network/network_device_handler_impl.h
+++ b/chromeos/network/network_device_handler_impl.h
@@ -11,6 +11,7 @@
#include "base/callback.h"
#include "base/compiler_specific.h"
#include "base/macros.h"
+#include "base/memory/weak_ptr.h"
#include "chromeos/chromeos_export.h"
#include "chromeos/network/network_device_handler.h"
#include "chromeos/network/network_handler.h"
@@ -134,13 +135,19 @@ class CHROMEOS_EXPORT NetworkDeviceHandlerImpl
// Apply the current value of |mac_addr_randomization_| to wifi devices.
void ApplyMACAddressRandomizationToShill();
+ void SetMACAddressRandomizationErrorCallback(
+ const std::string& error_name,
+ std::unique_ptr<base::DictionaryValue> error_data);
+
// Get the DeviceState for the wifi device, if any.
const DeviceState* GetWifiDeviceState(
const network_handler::ErrorCallback& error_callback);
NetworkStateHandler* network_state_handler_;
bool cellular_allow_roaming_;
- bool mac_addr_randomization_;
+ bool mac_addr_randomization_supported_;
+ bool mac_addr_randomization_enabled_;
+ base::WeakPtrFactory<NetworkDeviceHandlerImpl> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(NetworkDeviceHandlerImpl);
};
« no previous file with comments | « no previous file | chromeos/network/network_device_handler_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698