Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2202483002: Storage manager: Hide "Offline files" when Google Drive volume is not mounted. (Closed)

Created:
4 years, 4 months ago by fukino
Modified:
4 years, 4 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Storage manager: Hide "Offline files" when Google Drive volume is not mounted. The "Google Drive" volume in Files app does not always exist. (e.g. Guest session, Supervised user, or disabled by setting.) Showing "Offline files" in storage manager doesn't make sense in such cases and causes a crash. We should hide "Offline files" item when Google Drive volume doesn't exist. BUG=629347 TEST=manually tested on a guest user and a supervised user. TBR=dbeam@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2184083002 Cr-Commit-Position: refs/heads/master@{#408315} (cherry picked from commit ad2b1015a4d81c54dfbd79f47ca2d58fbe7722d1) Committed: https://chromium.googlesource.com/chromium/src/+/6e99b5785da15f9d858c29548c5b46d8ac4b389a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M chrome/browser/resources/options/chromeos/storage_manager.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/options/chromeos/storage_manager.js View 3 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
fukino
4 years, 4 months ago (2016-08-01 06:19:25 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6e99b5785da15f9d858c29548c5b46d8ac4b389a.

Powered by Google App Engine
This is Rietveld 408576698