Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2184083002: Storage manager: Hide "Offline files" when Google Drive volume is not mounted. (Closed)

Created:
4 years, 4 months ago by fukino
Modified:
4 years, 4 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Storage manager: Hide "Offline files" when Google Drive volume is not mounted. The "Google Drive" volume in Files app does not always exist. (e.g. Guest session, Supervised user, or disabled by setting.) Showing "Offline files" in storage manager doesn't make sense in such cases and causes a crash. We should hide "Offline files" item when Google Drive volume doesn't exist. BUG=629347 TEST=manually tested on a guest user and a supervised user. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/ad2b1015a4d81c54dfbd79f47ca2d58fbe7722d1 Cr-Commit-Position: refs/heads/master@{#408315}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M chrome/browser/resources/options/chromeos/storage_manager.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/options/chromeos/storage_manager.js View 3 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
fukino
PTAL.
4 years, 4 months ago (2016-07-27 11:09:33 UTC) #3
Dan Beam
lgtm although maybe you should start thinking about tests if this is causing crashes
4 years, 4 months ago (2016-07-27 13:03:11 UTC) #4
fukino
On 2016/07/27 13:03:11, Dan Beam wrote: > lgtm although maybe you should start thinking about ...
4 years, 4 months ago (2016-07-28 00:52:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2184083002/1
4 years, 4 months ago (2016-07-28 00:53:28 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 02:30:21 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 02:31:47 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad2b1015a4d81c54dfbd79f47ca2d58fbe7722d1
Cr-Commit-Position: refs/heads/master@{#408315}

Powered by Google App Engine
This is Rietveld 408576698