Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2202463002: ALL-IN-ONE Stop SpellChecker from checking or marking grammar (Closed)

Created:
4 years, 4 months ago by Xiaocheng
Modified:
4 years, 4 months ago
Reviewers:
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop SpellChecker from checking or marking grammar In this patch, all member functions of SpellChecker no longer search for or mark grammar mistakes. The following refactoring are also done for code simplification: 1. A private function of SpellChecker no longer takes grammar-related parameters or has the word "grammar" in their names. It is completely removed if it only performs grammar checking. 2. If a wrapper function is made trivial after step 1, it absorbs the body of the wrapped function. This step applies to markMisspellings() and markMisspellingsAndBadGrammar(). 3. resolveTextCheckingTypeMask() is removed because it is not used any more. WebFrameTest is also modified by removing everything related to grammar checking or marking. BUG=619452 TESt=n/a; no visible change

Patch Set 1 #

Patch Set 2 : Fix layout test accessibility/misspellings.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -290 lines) Patch
M third_party/WebKit/LayoutTests/accessibility/misspellings.html View 1 1 chunk +58 lines, -51 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h View 1 chunk +5 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 16 chunks +55 lines, -216 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 3 chunks +1 line, -15 lines 0 comments Download

Messages

Total messages: 12 (12 generated)
Xiaocheng
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-01 05:57:23 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202463002/1
4 years, 4 months ago (2016-08-01 05:57:31 UTC) #2
Xiaocheng
Description was changed from ========== Stop SpellChecking from checking or marking grammar mistakes BUG=619452 TESt=n/a; ...
4 years, 4 months ago (2016-08-01 06:07:30 UTC) #3
Xiaocheng
Description was changed from ========== Stop SpellChecking from checking or marking grammar BUG=619452 TESt=n/a; no ...
4 years, 4 months ago (2016-08-01 06:28:30 UTC) #4
Xiaocheng
xiaochengh@chromium.org changed reviewers: + yosin@chromium.org
4 years, 4 months ago (2016-08-01 06:28:30 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-01 07:00:23 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/271954)
4 years, 4 months ago (2016-08-01 07:00:23 UTC) #7
Xiaocheng
xiaochengh@chromium.org changed reviewers: - yosin@chromium.org
4 years, 4 months ago (2016-08-01 08:44:31 UTC) #8
Xiaocheng
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-01 10:36:50 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202463002/20001
4 years, 4 months ago (2016-08-01 10:36:57 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-01 11:53:55 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 11:53:56 UTC) #12
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698