Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h

Issue 2202463002: ALL-IN-ONE Stop SpellChecker from checking or marking grammar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix layout test accessibility/misspellings.html Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h
diff --git a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h
index 7797ebbeb1f44664184ce389ab522ed0e67c9d0e..a032e367902583404973c4b8ed39a1a04cec312c 100644
--- a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h
+++ b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h
@@ -102,18 +102,15 @@ private:
}
bool markMisspellings(const VisibleSelection&);
- void markBadGrammar(const VisibleSelection&);
- bool markMisspellingsOrBadGrammar(const VisibleSelection&, bool checkSpelling);
- void markMisspellingsAndBadGrammar(const VisibleSelection& spellingSelection, bool markGrammar, const VisibleSelection& grammarSelection);
- void markAllMisspellingsAndBadGrammarInRanges(TextCheckingTypeMask, const EphemeralRange& spellingRange, const EphemeralRange& grammarRange);
+ void markAllMisspellingsInRange(const EphemeralRange&);
+ void chunkAndMarkAllMisspellings(const TextCheckingParagraph&);
void spellCheckOldSelection(const VisibleSelection& oldSelection, const VisibleSelection& newAdjacentWords);
- TextCheckingTypeMask resolveTextCheckingTypeMask(TextCheckingTypeMask);
-
void removeMarkers(const VisibleSelection&, DocumentMarker::MarkerTypes);
- bool unifiedTextCheckerEnabled() const;
- void chunkAndMarkAllMisspellingsAndBadGrammar(TextCheckingTypeMask textCheckingOptions, const TextCheckingParagraph& fullParagraphToCheck);
+ // TODO(xiaochengh): crbug.com/619452 This function should always return true.
+ // "Unified text checker" is a meaningless term because there is only spelling checking.
+ bool unifiedTextCheckerEnabled() const;
Member<LocalFrame> m_frame;
const Member<SpellCheckRequester> m_spellCheckRequester;

Powered by Google App Engine
This is Rietveld 408576698