tools/mb/mb.py - Issue 2202393002: swarming: wholesale switch remaining tests to run on Swarming.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/mb/mb.py

Issue 2202393002: swarming: wholesale switch remaining tests to run on Swarming. (Closed) Base URL: https://chromium.googlesource.com/a/chromium/src.git@master

Patch Set: Oops Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/mb/mb.py

diff --git a/tools/mb/mb.py b/tools/mb/mb.py

index ff75f84dac33ba2afc24b6b615d215ceb896d7e7..c82fb9044c9c3df6f668c5762bb29c174ffcacea 100755

--- a/tools/mb/mb.py

+++ b/tools/mb/mb.py

@@ -1057,8 +1057,9 @@ class MetaBuildWrapper(object):

'--test-launcher-bot-mode',

'--enable-gpu',

'--test-launcher-jobs=1',

- '--gtest_filter=%s' % gtest_filter,

]

+ if gtest_filter:

+ cmdline.extend(('--gtest_filter=%s' % gtest_filter))

Dirk Pranke 2016/08/03 22:33:44 ick. I'm surprised this didn't cause more problems

M-A Ruel 2016/08/03 22:37:58 This was broken, fixed in patchset 4.

elif test_type == 'script':

extra_files = [

'../../testing/test_env.py'

« no previous file with comments | « testing/buildbot/manage.py ('k') | ui/chromeos/BUILD.gn » ('j') | no next file with comments »