Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: tools/perf/benchmarks/page_cycler.py

Issue 2202333002: Remove page_cycler.top_10_mobile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Completely remove benchmark. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/page_cycler.py
diff --git a/tools/perf/benchmarks/page_cycler.py b/tools/perf/benchmarks/page_cycler.py
index 21f3449e76b48a3f95bcbcb2731e488fd8d04bb2..e8883146a8476a09a6bfa7116e54771e2f282e17 100644
--- a/tools/perf/benchmarks/page_cycler.py
+++ b/tools/perf/benchmarks/page_cycler.py
@@ -116,31 +116,6 @@ class PageCyclerIntlKoThVi(_PageCycler):
possible_browser.platform.GetOSVersionName() == 'snowleopard'))
-@benchmark.Enabled('android')
-class PageCyclerTop10Mobile(_PageCycler):
- """Page load time benchmark for the top 10 mobile web pages.
-
- Runs against pages recorded in November, 2013.
- """
-
- @classmethod
- def Name(cls):
- return 'page_cycler.top_10_mobile'
-
- def CreateStorySet(self, options):
- # Disable the taobao.com page since it's crashing. crbug.com/509690
- stories = page_sets.Top10MobilePageSet(run_no_page_interactions=True)
- found = next((x for x in stories if 'taobao.com' in x.url), None)
- if found:
- stories.RemoveStory(found)
- return stories
-
- @classmethod
- def ShouldDisable(cls, possible_browser):
- # http://crbug.com/633222 (Android Nexus 5).
- return possible_browser.platform.GetDeviceTypeName() == 'Nexus 5'
-
-
@benchmark.Disabled('android') # crbug.com/357326
class PageCyclerToughLayoutCases(_PageCycler):
"""Page loading for the slowest layouts observed in the Alexa top 1 million.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698