Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: tools/perf/benchmarks/page_cycler.py

Issue 2202333002: Remove page_cycler.top_10_mobile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Completely remove benchmark. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from core import perf_benchmark 5 from core import perf_benchmark
6 6
7 from measurements import page_cycler 7 from measurements import page_cycler
8 import page_sets 8 import page_sets
9 from telemetry import benchmark 9 from telemetry import benchmark
10 10
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 109
110 @classmethod 110 @classmethod
111 def ShouldDisable(cls, possible_browser): 111 def ShouldDisable(cls, possible_browser):
112 # http://crbug.com/597656 (Android Nexus 5X). 112 # http://crbug.com/597656 (Android Nexus 5X).
113 # http://crbug.com/605543 (Mac Snow Leopard). 113 # http://crbug.com/605543 (Mac Snow Leopard).
114 return (possible_browser.browser_type == 'reference' and ( 114 return (possible_browser.browser_type == 'reference' and (
115 possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X' or 115 possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X' or
116 possible_browser.platform.GetOSVersionName() == 'snowleopard')) 116 possible_browser.platform.GetOSVersionName() == 'snowleopard'))
117 117
118 118
119 @benchmark.Enabled('android')
120 class PageCyclerTop10Mobile(_PageCycler):
121 """Page load time benchmark for the top 10 mobile web pages.
122
123 Runs against pages recorded in November, 2013.
124 """
125
126 @classmethod
127 def Name(cls):
128 return 'page_cycler.top_10_mobile'
129
130 def CreateStorySet(self, options):
131 # Disable the taobao.com page since it's crashing. crbug.com/509690
132 stories = page_sets.Top10MobilePageSet(run_no_page_interactions=True)
133 found = next((x for x in stories if 'taobao.com' in x.url), None)
134 if found:
135 stories.RemoveStory(found)
136 return stories
137
138 @classmethod
139 def ShouldDisable(cls, possible_browser):
140 # http://crbug.com/633222 (Android Nexus 5).
141 return possible_browser.platform.GetDeviceTypeName() == 'Nexus 5'
142
143
144 @benchmark.Disabled('android') # crbug.com/357326 119 @benchmark.Disabled('android') # crbug.com/357326
145 class PageCyclerToughLayoutCases(_PageCycler): 120 class PageCyclerToughLayoutCases(_PageCycler):
146 """Page loading for the slowest layouts observed in the Alexa top 1 million. 121 """Page loading for the slowest layouts observed in the Alexa top 1 million.
147 122
148 Recorded in July 2013. 123 Recorded in July 2013.
149 """ 124 """
150 page_set = page_sets.ToughLayoutCasesPageSet 125 page_set = page_sets.ToughLayoutCasesPageSet
151 126
152 @classmethod 127 @classmethod
153 def Name(cls): 128 def Name(cls):
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 set, without running in out-of-process iframes mode.. """ 173 set, without running in out-of-process iframes mode.. """
199 page_set = page_sets.OopifBasicPageSet 174 page_set = page_sets.OopifBasicPageSet
200 175
201 @classmethod 176 @classmethod
202 def Name(cls): 177 def Name(cls):
203 return 'page_cycler.basic_oopif' 178 return 'page_cycler.basic_oopif'
204 179
205 @classmethod 180 @classmethod
206 def ShouldDisable(cls, possible_browser): 181 def ShouldDisable(cls, possible_browser):
207 return cls.IsSvelte(possible_browser) # http://crbug.com/607657 182 return cls.IsSvelte(possible_browser) # http://crbug.com/607657
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698