components/offline_pages/background/request_queue_store_unittest.cc - Issue 2202113002: API to provide status of save page reqeusts to API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/request_queue_store_unittest.cc

Issue 2202113002: API to provide status of save page reqeusts to API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/offline_pages/background/request_queue_in_memory_store.cc ('K') | « components/offline_pages/background/request_queue_in_memory_store.cc ('k') | components/offline_pages/background/request_status.h » ('j') | components/offline_pages/background/request_status.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/background/request_queue_store_unittest.cc

diff --git a/components/offline_pages/background/request_queue_store_unittest.cc b/components/offline_pages/background/request_queue_store_unittest.cc

index 7a75be9d265f4bf3db0c0a934551bcc8d0265ba4..df9a6e0e63bc9065bef6c74105103588669dbb1a 100644

--- a/components/offline_pages/background/request_queue_store_unittest.cc

+++ b/components/offline_pages/background/request_queue_store_unittest.cc

@@ -114,6 +114,7 @@ void RequestQueueStoreTestBase::ClearResults() {

void RequestQueueStoreTestBase::GetRequestsDone(

bool result,

const std::vector<SavePageRequest>& requests) {

+ DVLOG(0) << "@@@@@@ " << __func__;

fgorski 2016/08/02 04:18:12 nit: do you need to keep this?

Pete Williamson 2016/08/03 00:24:32 Done.

last_result_ = result ? LastResult::kTrue : LastResult::kFalse;

last_requests_ = requests;

}