components/offline_pages/background/request_queue_in_memory_store.cc - Issue 2202113002: API to provide status of save page reqeusts to API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/request_queue_in_memory_store.cc

Issue 2202113002: API to provide status of save page reqeusts to API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/offline_pages/background/request_queue.cc ('K') | « components/offline_pages/background/request_queue.cc ('k') | components/offline_pages/background/request_queue_store_unittest.cc » ('j') | components/offline_pages/background/request_queue_store_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/background/request_queue_in_memory_store.cc

diff --git a/components/offline_pages/background/request_queue_in_memory_store.cc b/components/offline_pages/background/request_queue_in_memory_store.cc

index defb87e311ffed9c84328e47b31764f9da3d00d9..491420140aa66df2c1faaed896c5a08590c1d06e 100644

--- a/components/offline_pages/background/request_queue_in_memory_store.cc

+++ b/components/offline_pages/background/request_queue_in_memory_store.cc

@@ -18,8 +18,9 @@ RequestQueueInMemoryStore::~RequestQueueInMemoryStore() {}

void RequestQueueInMemoryStore::GetRequests(

const GetRequestsCallback& callback) {

std::vector<SavePageRequest> result_requests;

- for (const auto& id_request_pair : requests_)

+ for (const auto& id_request_pair : requests_) {

fgorski 2016/08/02 04:18:12 nit: do you need the braces here?

Pete Williamson 2016/08/03 00:24:32 Done.

result_requests.push_back(id_request_pair.second);

+ }

base::ThreadTaskRunnerHandle::Get()->PostTask(

FROM_HERE, base::Bind(callback, true, result_requests));

}