Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2202033002: ui: Remove unneeded RegisterNatives() call on Android (Closed)

Created:
4 years, 4 months ago by no sievers
Modified:
4 years, 4 months ago
Reviewers:
sadrul, Torne
CC:
chromium-reviews, Dirk Pranke, dcheng, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@jnireg1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui: Remove unneeded RegisterNatives() call on Android BUG=603936 Committed: https://crrev.com/56d5d644371428a2f6651ea764cc5bf377552e16 Cr-Commit-Position: refs/heads/master@{#409287}

Patch Set 1 #

Patch Set 2 : ui: Remove unneeded RegisterNatives() call on Android #

Patch Set 3 : rebase, unused headers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -164 lines) Patch
M content/app/android/library_loader_hooks.cc View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M content/public/test/content_test_suite_base.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M ui/base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/android/ui_base_jni_registrar.cc View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M ui/base/clipboard/clipboard_android.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/base/clipboard/clipboard_android.cc View 1 chunk +0 lines, -4 lines 0 comments Download
D ui/base/device_form_factor_android.h View 1 chunk +0 lines, -18 lines 0 comments Download
M ui/base/device_form_factor_android.cc View 2 chunks +1 line, -5 lines 0 comments Download
M ui/base/resource/resource_bundle_android.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/base/resource/resource_bundle_android.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/base/touch/touch_device.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/base/touch/touch_device_android.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/base/ui_base.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/BUILD.gn View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
D ui/events/android/events_jni_registrar.h View 1 chunk +0 lines, -25 lines 0 comments Download
D ui/events/android/events_jni_registrar.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M ui/events/android/key_event_utils.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/events/android/key_event_utils.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/events/android/motion_event_android.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/events/android/motion_event_android.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/events/events.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gfx/android/gfx_jni_registrar.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/gfx/android/java_bitmap.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/gfx/android/java_bitmap.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/gl/android/gl_jni_registrar.cc View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M ui/gl/android/scoped_java_surface.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M ui/gl/android/surface_texture.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gl/android/surface_texture.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
no sievers
+torne and +sadrul for owners
4 years, 4 months ago (2016-08-01 22:33:51 UTC) #3
Torne
I don't think I'm an owner for any files in this CL, but LGTM :)
4 years, 4 months ago (2016-08-02 12:26:42 UTC) #12
sadrul
lgtm
4 years, 4 months ago (2016-08-02 16:23:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202033002/40001
4 years, 4 months ago (2016-08-02 18:47:51 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-02 19:59:27 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 20:01:29 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/56d5d644371428a2f6651ea764cc5bf377552e16
Cr-Commit-Position: refs/heads/master@{#409287}

Powered by Google App Engine
This is Rietveld 408576698