fix optional params to mock methods, allow all signatures

fix optional params to mock methods, allow all signatures
switches to use the same technique as `dsend`

R=vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/e5c2aac3fbb503fe0ede030dca9bfdc36bb0093a

[Jennifer Messerly, 2016-08-01 21:23:48]

Patchset #1 (id:1) has been deleted

[Jennifer Messerly, 2016-08-01 21:28:37]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[Jennifer Messerly, 2016-08-01 21:28:38]

This fixes the issue described in CL
https://codereview.chromium.org/2202673002/, along with manual verification of
that test case, it adds some coverage to the language tests.

Idea here is to use rest params to avoid worrying about signatures. Actually not
sure why I didn't do it this way in the first place ... thought of it soon after
landing :). As a bonus we're more permissive about the signatures, so we could
allow any signature statically if we wanted to.

[Jennifer Messerly, 2016-08-01 22:38:12]

Update: getters/setters were kind of broken in the first patch (thanks Sam for
catching) ... should be fixed now

[srawlins, 2016-08-01 22:53:27]

On 2016/08/01 22:38:12, John Messerly wrote:
> Update: getters/setters were kind of broken in the first patch (thanks Sam for
> catching) ... should be fixed now

lgtm!

This patch works on the strong subset of Mockito. Looks great from my side.

[vsm, 2016-08-01 23:14:32]

lgtm

https://codereview.chromium.org/2201973002/diff/60001/test/codegen/language/n...
File test/codegen/language/no_such_method_mock_test.dart (right):

https://codereview.chromium.org/2201973002/diff/60001/test/codegen/language/n...
test/codegen/language/no_such_method_mock_test.dart:62: Expect.throws(() =>
mock.scratch("couch") + '');
Does this really get to +?  That would be a soundness problem.  The stub for
Mock.scratch tests the result is String, right?

https://codereview.chromium.org/2201973002/diff/60001/test/codegen_expected/l...
File test/codegen_expected/language/cyclic_import_test.js (right):

https://codereview.chromium.org/2201973002/diff/60001/test/codegen_expected/l...
test/codegen_expected/language/cyclic_import_test.js:281:
cyclic_import_test$132.value = 42;
Unrelated to your CL - but maybe something unstable here?

[Jennifer Messerly, 2016-08-01 23:18:01]

thanks!

https://codereview.chromium.org/2201973002/diff/60001/test/codegen/language/n...
File test/codegen/language/no_such_method_mock_test.dart (right):

https://codereview.chromium.org/2201973002/diff/60001/test/codegen/language/n...
test/codegen/language/no_such_method_mock_test.dart:62: Expect.throws(() =>
mock.scratch("couch") + '');
On 2016/08/01 23:14:32, vsm wrote:
> Does this really get to +?  That would be a soundness problem.  The stub for
> Mock.scratch tests the result is String, right?

It doesn't get there in strong mode (nSM returns bool and cast fails to String).
It's for Dart VM if we merge this back into language tests (see comment).

https://codereview.chromium.org/2201973002/diff/60001/test/codegen_expected/l...
File test/codegen_expected/language/cyclic_import_test.js (right):

https://codereview.chromium.org/2201973002/diff/60001/test/codegen_expected/l...
test/codegen_expected/language/cyclic_import_test.js:281:
cyclic_import_test$132.value = 42;
On 2016/08/01 23:14:32, vsm wrote:
> Unrelated to your CL - but maybe something unstable here?

yup. Not sure what though...

[vsm, 2016-08-01 23:19:31]

lgtm

https://codereview.chromium.org/2201973002/diff/60001/test/codegen/language/n...
File test/codegen/language/no_such_method_mock_test.dart (right):

https://codereview.chromium.org/2201973002/diff/60001/test/codegen/language/n...
test/codegen/language/no_such_method_mock_test.dart:62: Expect.throws(() =>
mock.scratch("couch") + '');
On 2016/08/01 23:18:00, John Messerly wrote:
> On 2016/08/01 23:14:32, vsm wrote:
> > Does this really get to +?  That would be a soundness problem.  The stub for
> > Mock.scratch tests the result is String, right?
> 
> It doesn't get there in strong mode (nSM returns bool and cast fails to
String).
> It's for Dart VM if we merge this back into language tests (see comment).

Ah, misread your comment.  thanks.  :-)

[Jennifer Messerly, 2016-08-01 23:22:06]

Description was changed from

==========
fix optional params to mock methods, allow all signatures
switches to use the same technique as `dsend`
==========

to

==========
fix optional params to mock methods, allow all signatures
switches to use the same technique as `dsend`

R=vsm@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/e5c2aac3fbb503fe0ede030dca9b...
==========

[Jennifer Messerly, 2016-08-01 23:22:09]

Committed patchset #3 (id:60001) manually as
e5c2aac3fbb503fe0ede030dca9bfdc36bb0093a (presubmit successful).