fix optional params to mock methods, allow all signatures

lib/src/compiler/code_generator.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:collection' show HashMap, HashSet;
 import 'dart:math' show min, max;
 
 import 'package:analyzer/analyzer.dart' hide ConstantEvaluator;
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/token.dart' show Token, TokenType;
@@ skipping 1386 matching lines @@
   ///
   ///     class Cat {
   ///       bool eatFood(String food) => true;
   ///     }
   ///     class MockCat implements Cat {
   ///        noSuchMethod(Invocation invocation) => 3;
   ///     }
   ///
   /// It will generate an `eatFood` that looks like:
   ///
-  ///     eatFood(food) {
+  ///     eatFood(...args) {
   ///       return core.bool.as(this.noSuchMethod(
-  ///           new dart.InvocationImpl('eatFood', [food])));
+  ///           new dart.InvocationImpl('eatFood', args)));
   ///     }
   JS.Method _implementMockMethod(ExecutableElement method) {
-    var positionalArgs = <JS.Identifier>[]
-      ..addAll(
-          method.type.normalParameterNames.map((a) => new JS.Identifier(a)))
-      ..addAll(
-          method.type.optionalParameterNames.map((a) => new JS.Identifier(a)));
-
-    var fnArgs = positionalArgs.toList();
-
     var invocationProps = <JS.Property>[];
     addProperty(String name, JS.Expression value) {
       invocationProps.add(new JS.Property(js.string(name), value));
     }
 
+    var args = new JS.TemporaryId('args');
+    var fnArgs = <JS.Parameter>[];
+    JS.Expression positionalArgs;;
+
     if (method.type.namedParameterTypes.isNotEmpty) {
-      fnArgs.add(namedArgumentTemp);
-      addProperty('namedArguments', namedArgumentTemp);
+      addProperty(
+          'namedArguments', js.call('dart.extractNamedArgs(#)', [args]));
     }
 
     if (method is MethodElement) {
       addProperty('isMethod', js.boolean(true));
+
+      fnArgs.add(new JS.RestParameter(args));
+      positionalArgs = args;
     } else {
       var property = method as PropertyAccessorElement;
       if (property.isGetter) {
         addProperty('isGetter', js.boolean(true));
+
+        positionalArgs = new JS.ArrayInitializer([]);
       } else if (property.isSetter) {
         addProperty('isSetter', js.boolean(true));
+
+        fnArgs.add(args);
+        positionalArgs = new JS.ArrayInitializer([args]);
       }
     }
 
-    var fnBody =
-        js.call('this.noSuchMethod(new dart.InvocationImpl(#, #, #))', [
+    var fnBody = js.call(
+        'this.noSuchMethod(new dart.InvocationImpl(#, #, #))', [
       _elementMemberName(method),
-      new JS.ArrayInitializer(positionalArgs),
+      positionalArgs,
       new JS.ObjectInitializer(invocationProps)
     ]);
 
     if (!method.returnType.isDynamic) {
       fnBody = js.call('#._check(#)', [_emitType(method.returnType), fnBody]);
     }
 
     var fn = new JS.Fun(fnArgs, js.statement('{ return #; }', [fnBody]),
         typeParams: _emitTypeFormals(method.type.typeFormals));
 
@@ skipping 3907 matching lines @@
 }
 
 bool isLibraryPrefix(Expression node) =>
     node is SimpleIdentifier && node.staticElement is PrefixElement;
 
 LibraryElement _getLibrary(AnalysisContext c, String uri) =>
     c.computeLibraryElement(c.sourceFactory.forUri(uri));
 
 bool _isDartRuntime(LibraryElement l) =>
     l.isInSdk && l.source.uri.toString() == 'dart:_runtime';