gn: Don't let libyuv depend on libjpeg_turbo.

gn: Don't let libyuv depend on libjpeg_turbo on iOS.

This dependency doesn't exist in the gyp build either, and it causes
problems on builds building 'all'.

BUG=633316
R=kjellander@chromium.org

Committed: https://chromium.googlesource.com/libyuv/libyuv/+/68786ccd538471a7fb041bcf110792655618b4a2

[Nico, 2016-08-01 21:06:04]

thakis@chromium.org changed reviewers:
+ dpranke@chromium.org

[Nico, 2016-08-01 21:06:04]

thakis@chromium.org changed reviewers:
+ dpranke@chromium.org

[Nico, 2016-08-01 21:08:22]

(looks like the trybots don't work for libyuv changes)

[Nico, 2016-08-01 21:11:37]

thakis@chromium.org changed reviewers:
+ kjellander@chromium.org

[Nico, 2016-08-01 21:11:37]

+kjellander 'cause I think I saw him change libyuv/webrtc-related things
somewhere

[Nico, 2016-08-01 21:12:43]

thakis@chromium.org changed reviewers:
+ fbarchard@chromium.org

[Nico, 2016-08-01 21:12:43]

and +fbarchard since libyuv

[kjellander_chromium, 2016-08-01 21:24:08]

lgtm
trybots should work, I think your checkout is just outdated since this change
has been committed since:
https://chromium.googlesource.com/libyuv/libyuv/+/5dbfd6d8e61b814ed8112f765f9...

[Dirk Pranke, 2016-08-01 21:32:56]

I defer to kjellander here.

[Nico, 2016-08-01 21:39:37]

`git cl land` won't let me land:
thakis-macpro:libyuv thakis$ git cl land
Using 50% similarity for rename/copy detection. Override with --similarity.
Running presubmit commit checks ...

Presubmit checks passed.
Description:
gn: Don't let libyuv depend on libjpeg_turbo on iOS.

This dependency doesn't exist in the gyp build either, and it causes
problems on builds building 'all'.

BUG=633316
R=kjellander@chromium.org

Review URL: https://codereview.chromium.org/2201963002 .
 BUILD.gn | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
Counting objects: 3, done.
Delta compression using up to 24 threads.
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 498 bytes | 0 bytes/s, done.
Total 3 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2)
remote: Processing changes: refs: 1, done    
error: failed to push some refs to
'https://chromium.googlesource.com/libyuv/libyuv.git'
Failed to push. If this persists, please file a bug.
thakis-macpro:libyuv thakis$ 


What am I doing wrong?

[kjellander_chromium, 2016-08-02 05:01:03]

On 2016/08/01 21:39:37, Nico wrote:
> `git cl land` won't let me land:
> thakis-macpro:libyuv thakis$ git cl land
> Using 50% similarity for rename/copy detection. Override with --similarity.
> Running presubmit commit checks ...
> 
> Presubmit checks passed.
> Description:
> gn: Don't let libyuv depend on libjpeg_turbo on iOS.
> 
> This dependency doesn't exist in the gyp build either, and it causes
> problems on builds building 'all'.
> 
> BUG=633316
> mailto:R=kjellander@chromium.org
> 
> Review URL: https://codereview.chromium.org/2201963002 .
>  BUILD.gn | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> Counting objects: 3, done.
> Delta compression using up to 24 threads.
> Compressing objects: 100% (3/3), done.
> Writing objects: 100% (3/3), 498 bytes | 0 bytes/s, done.
> Total 3 (delta 2), reused 0 (delta 0)
> remote: Resolving deltas: 100% (2/2)
> remote: Processing changes: refs: 1, done    
> error: failed to push some refs to
> 'https://chromium.googlesource.com/libyuv/libyuv.git'
> Failed to push. If this persists, please file a bug.
> thakis-macpro:libyuv thakis$ 
> 
> 
> What am I doing wrong?

You're simply not a libyuv committer. I added you for push access now so please
just try again.

[Nico, 2016-08-02 13:52:57]

Description was changed from

==========
gn: Don't let libyuv depend on libjpeg_turbo on iOS.

This dependency doesn't exist in the gyp build either, and it causes
problems on builds building 'all'.

BUG=633316
==========

to

==========
gn: Don't let libyuv depend on libjpeg_turbo on iOS.

This dependency doesn't exist in the gyp build either, and it causes
problems on builds building 'all'.

BUG=633316
R=kjellander@chromium.org

Committed:
https://chromium.googlesource.com/libyuv/libyuv/+/68786ccd538471a7fb041bcf110...
==========

[Nico, 2016-08-02 13:52:58]

Committed patchset #3 (id:40001) manually as
68786ccd538471a7fb041bcf110792655618b4a2 (presubmit successful).

[fbarchard1, 2016-08-02 21:49:11]

fbarchard@google.com changed reviewers:
+ fbarchard@google.com

[fbarchard1, 2016-08-02 21:49:11]

lgtm thanks.

Note that bug 603 is for enabling/fixing jpeg for ios, so followup later with
enabling jpeg if possible.
https://bugs.chromium.org/p/libyuv/issues/detail?id=603