Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2201893008: [serial] Only add a watcher if if the immeidate read attempt fails. (Closed)

Created:
4 years, 4 months ago by aschulman
Modified:
4 years, 4 months ago
CC:
chromium-reviews, charliea (OOO until 10-5)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[serial] Only add a watcher if if the immeidate read attempt fails. BUG=634278 Committed: https://crrev.com/577a8466eb739efbe3ba7887e64f9b230f62de0c Cr-Commit-Position: refs/heads/master@{#409917}

Patch Set 1 #

Patch Set 2 : Moved to EAGAIN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M device/serial/serial_io_handler_posix.h View 1 chunk +1 line, -1 line 0 comments Download
M device/serial/serial_io_handler_posix.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
aschulman
4 years, 4 months ago (2016-08-04 09:40:54 UTC) #3
Reilly Grant (use Gerrit)
I think you could also move the call to EnsureWatchingReads() into the EAGAIN case but ...
4 years, 4 months ago (2016-08-04 17:55:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2201893008/20001
4 years, 4 months ago (2016-08-04 20:47:16 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-04 22:30:34 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 22:33:50 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/577a8466eb739efbe3ba7887e64f9b230f62de0c
Cr-Commit-Position: refs/heads/master@{#409917}

Powered by Google App Engine
This is Rietveld 408576698