device/serial/serial_io_handler_posix.h - Issue 2201893008: [serial] Only add a watcher if if the immeidate read attempt fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/serial/serial_io_handler_posix.h

Issue 2201893008: [serial] Only add a watcher if if the immeidate read attempt fails. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved to EAGAIN Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: device/serial/serial_io_handler_posix.h

diff --git a/device/serial/serial_io_handler_posix.h b/device/serial/serial_io_handler_posix.h

index 28f10c434a7135ec14d4b1ea1e1d3dca6df1e90d..b25f7c8731bc8c18cafca04025e70b6c9576cf8f 100644

--- a/device/serial/serial_io_handler_posix.h

+++ b/device/serial/serial_io_handler_posix.h

@@ -49,7 +49,7 @@ class SerialIoHandlerPosix : public SerialIoHandler,

scoped_refptr<base::SingleThreadTaskRunner> ui_thread_task_runner);

~SerialIoHandlerPosix() override;

- void AttemptRead(bool within_read);

+ bool AttemptRead(bool within_read);

void RunReadCompleted(bool within_read,

int bytes_read,

serial::ReceiveError error);

« no previous file with comments | « no previous file | device/serial/serial_io_handler_posix.cc » ('j') | no next file with comments »