Geolocation: move mojom from WebKit to device/geolocation/public/interfaces

Geolocation: move mojom from WebKit to device/geolocation/public/interfaces

This CL moves geolocation.mojom from its location in third_party/WebKit
to device/geolocation/public/interfaces (following the example of its
peers in device/).
Call/include sites updated. Changed to using new mojo wrapper types.

BUG=612334
Committed: https://crrev.com/8720394fae3de0684dbe539423483ca1195b06f4
Cr-Commit-Position: refs/heads/master@{#409646}

[mcasas, 2016-08-01 21:51:47]

Description was changed from

==========
Geolocation: move mojom from WebKit to device/geolocation/public/interfaces

This CL moved geolocation.mojom from its location in third_party/WebKit,
to device/geolocation/public/interfaces (like all its peers in device/).
Call/include sites updated, and changed to using new mojo wrapper types.

BUG=612334
==========

to

==========
Geolocation: move mojom from WebKit to device/geolocation/public/interfaces

This CL moves geolocation.mojom from its location in third_party/WebKit
to device/geolocation/public/interfaces (following the example of its
peers in device/).
Call/include sites updated. Changed to using new mojo wrapper types.

BUG=612334
==========

[mcasas, 2016-08-01 22:06:36]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 22:06:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mcasas, 2016-08-01 23:22:18]

Patchset #1 (id:1) has been deleted

[mcasas, 2016-08-01 23:23:20]

mcasas@chromium.org changed reviewers:
+ ortuno@chromium.org

[mcasas, 2016-08-01 23:23:21]

ortuno@ following up on [1], PTAL

[1] https://codereview.chromium.org/2184013004/#msg20

[commit-bot: I haz the power, 2016-08-01 23:49:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 23:49:42]

Dry run: This issue passed the CQ dry run.

[ortuno, 2016-08-02 14:55:43]

ortuno@chromium.org changed reviewers:
+ rockot@chromium.org

[ortuno, 2016-08-02 14:55:45]

Adding rockot to make sure I'm not talking non-sense :)

https://codereview.chromium.org/2201883003/diff/20001/content/browser/BUILD.gn
File content/browser/BUILD.gn (right):

https://codereview.chromium.org/2201883003/diff/20001/content/browser/BUILD.g...
content/browser/BUILD.gn:67:
"//device/geolocation/public/interfaces:geolocation_mojom",
You can also remove
"third_party/WebKit/public/platform/modules/geolocation/geolocation.mojom.h"
from content/browser/DEPS

https://codereview.chromium.org/2201883003/diff/20001/device/geolocation/BUIL...
File device/geolocation/BUILD.gn (right):

https://codereview.chromium.org/2201883003/diff/20001/device/geolocation/BUIL...
device/geolocation/BUILD.gn:11: component("device_geolocation") {
Shouldn't this be split into two separate targets? One for the service and one
for everything else. There are users of device/geolocation that don't need the
service or the bindings e.g. autofill.

https://codereview.chromium.org/2201883003/diff/20001/device/geolocation/publ...
File device/geolocation/public/interfaces/BUILD.gn (right):

https://codereview.chromium.org/2201883003/diff/20001/device/geolocation/publ...
device/geolocation/public/interfaces/BUILD.gn:7: mojom("geolocation_mojom") {
nit: I think this should be called mojo_bindings. It's clear from the path that
this mojom belongs to geolocation and this seems to already be a pattern:
device/nfc, device/vibration, device/vr...

[Ken Rockot(use gerrit already), 2016-08-02 16:10:03]

On 2016/08/02 at 14:55:45, ortuno wrote:
> Adding rockot to make sure I'm not talking non-sense :)
> 
> https://codereview.chromium.org/2201883003/diff/20001/content/browser/BUILD.gn
> File content/browser/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2201883003/diff/20001/content/browser/BUILD.g...
> content/browser/BUILD.gn:67:
"//device/geolocation/public/interfaces:geolocation_mojom",
> You can also remove
"third_party/WebKit/public/platform/modules/geolocation/geolocation.mojom.h"
from content/browser/DEPS
> 
>
https://codereview.chromium.org/2201883003/diff/20001/device/geolocation/BUIL...
> File device/geolocation/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2201883003/diff/20001/device/geolocation/BUIL...
> device/geolocation/BUILD.gn:11: component("device_geolocation") {
> Shouldn't this be split into two separate targets? One for the service and one
for everything else. There are users of device/geolocation that don't need the
service or the bindings e.g. autofill.
> 
>
https://codereview.chromium.org/2201883003/diff/20001/device/geolocation/publ...
> File device/geolocation/public/interfaces/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2201883003/diff/20001/device/geolocation/publ...
> device/geolocation/public/interfaces/BUILD.gn:7: mojom("geolocation_mojom") {
> nit: I think this should be called mojo_bindings. It's clear from the path
that this mojom belongs to geolocation and this seems to already be a pattern:
device/nfc, device/vibration, device/vr...

In general if a directory only has one main target, that target should share the
name of the directory. In this case the target should be called "interfaces",
which is a well established pattern for any mojom that live in an "interfaces"
directory.

[Ken Rockot(use gerrit already), 2016-08-02 16:23:33]

https://codereview.chromium.org/2201883003/diff/20001/device/geolocation/BUIL...
File device/geolocation/BUILD.gn (right):

https://codereview.chromium.org/2201883003/diff/20001/device/geolocation/BUIL...
device/geolocation/BUILD.gn:11: component("device_geolocation") {
On 2016/08/02 at 14:55:45, ortuno wrote:
> Shouldn't this be split into two separate targets? One for the service and one
for everything else. There are users of device/geolocation that don't need the
service or the bindings e.g. autofill.

Maybe, but it's not clear how much that matters. I think eventually anyone
consuming geolocation would be doing so through service interfaces. In that case
there would certainly be a target split, but it'd be to avoid dependencies on
the impl rather than avoiding them on the interfaces.

[mcasas, 2016-08-02 18:07:00]

Patchset #2 (id:40001) has been deleted

[mcasas, 2016-08-02 18:17:05]

PTAL

https://codereview.chromium.org/2201883003/diff/20001/content/browser/BUILD.gn
File content/browser/BUILD.gn (right):

https://codereview.chromium.org/2201883003/diff/20001/content/browser/BUILD.g...
content/browser/BUILD.gn:67:
"//device/geolocation/public/interfaces:geolocation_mojom",
On 2016/08/02 14:55:45, ortuno wrote:
> You can also remove
> "third_party/WebKit/public/platform/modules/geolocation/geolocation.mojom.h"
> from content/browser/DEPS

Done.

https://codereview.chromium.org/2201883003/diff/20001/device/geolocation/publ...
File device/geolocation/public/interfaces/BUILD.gn (right):

https://codereview.chromium.org/2201883003/diff/20001/device/geolocation/publ...
device/geolocation/public/interfaces/BUILD.gn:7: mojom("geolocation_mojom") {
On 2016/08/02 14:55:45, ortuno wrote:
> nit: I think this should be called mojo_bindings. It's clear from the path
that
> this mojom belongs to geolocation and this seems to already be a pattern:
> device/nfc, device/vibration, device/vr...

Renamed to just "interfaces" per rockot@
comment, and per usb/ example.

[ortuno, 2016-08-02 18:29:32]

lgtm

[mcasas, 2016-08-02 20:51:35]

mcasas@chromium.org changed reviewers:
+ avi@chromium.org, haraken@chromium.org

[mcasas, 2016-08-02 20:51:36]

avi@ RS deps-removals in content/

haraken@ plz RS WebKit

[haraken, 2016-08-03 00:40:42]

On 2016/08/02 20:51:36, mcasas wrote:
> avi@ RS deps-removals in content/
> 
> haraken@ plz RS WebKit

WebKit LGTM

[mcasas, 2016-08-03 17:14:46]

mcasas@chromium.org changed reviewers:
+ tsepez@chromium.org

[mcasas, 2016-08-03 17:14:47]

tsepez@ RS moving the mojom file plz

[Avi (use Gerrit), 2016-08-03 18:00:02]

lgtm

content stampity stamp

[Tom Sepez, 2016-08-03 18:58:05]

lgtm

[mcasas, 2016-08-03 19:15:25]

mcasas@chromium.org changed reviewers:
+ esprehn@chromium.org

[mcasas, 2016-08-03 19:15:26]

esprehn@ RS trivial changes in third_party/WebKit/public plz

[esprehn, 2016-08-03 19:58:33]

lgtm

[mcasas, 2016-08-03 19:59:20]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2016-08-03 19:59:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 22:42:52]

Description was changed from

==========
Geolocation: move mojom from WebKit to device/geolocation/public/interfaces

This CL moves geolocation.mojom from its location in third_party/WebKit
to device/geolocation/public/interfaces (following the example of its
peers in device/).
Call/include sites updated. Changed to using new mojo wrapper types.

BUG=612334
==========

to

==========
Geolocation: move mojom from WebKit to device/geolocation/public/interfaces

This CL moves geolocation.mojom from its location in third_party/WebKit
to device/geolocation/public/interfaces (following the example of its
peers in device/).
Call/include sites updated. Changed to using new mojo wrapper types.

BUG=612334
==========

[commit-bot: I haz the power, 2016-08-03 22:43:00]

Committed patchset #2 (id:50020)

[commit-bot: I haz the power, 2016-08-03 22:44:47]

Description was changed from

==========
Geolocation: move mojom from WebKit to device/geolocation/public/interfaces

This CL moves geolocation.mojom from its location in third_party/WebKit
to device/geolocation/public/interfaces (following the example of its
peers in device/).
Call/include sites updated. Changed to using new mojo wrapper types.

BUG=612334
==========

to

==========
Geolocation: move mojom from WebKit to device/geolocation/public/interfaces

This CL moves geolocation.mojom from its location in third_party/WebKit
to device/geolocation/public/interfaces (following the example of its
peers in device/).
Call/include sites updated. Changed to using new mojo wrapper types.

BUG=612334

Committed: https://crrev.com/8720394fae3de0684dbe539423483ca1195b06f4
Cr-Commit-Position: refs/heads/master@{#409646}
==========

[commit-bot: I haz the power, 2016-08-03 22:44:49]

Patchset 2 (id:??) landed as
https://crrev.com/8720394fae3de0684dbe539423483ca1195b06f4
Cr-Commit-Position: refs/heads/master@{#409646}