device/geolocation/public/interfaces/BUILD.gn - Issue 2201883003: Geolocation: move mojom from WebKit to device/geolocation/public/interfaces

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: device/geolocation/public/interfaces/BUILD.gn

Issue 2201883003: Geolocation: move mojom from WebKit to device/geolocation/public/interfaces (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import("//mojo/public/tools/bindings/mojom.gni")	5 import("//mojo/public/tools/bindings/mojom.gni")

6	6

7 mojom("interfaces") {	7 mojom("geolocation_mojom") {
	ortuno 2016/08/02 14:55:45 nit: I think this should be called mojo_bindings. nit: I think this should be called mojo_bindings. It's clear from the path that this mojom belongs to geolocation and this seems to already be a pattern: device/nfc, device/vibration, device/vr... mcasas 2016/08/02 18:17:04 Renamed to just "interfaces" per rockot@ comment, Show quoted text On 2016/08/02 14:55:45, ortuno wrote: > nit: I think this should be called mojo_bindings. It's clear from the path that > this mojom belongs to geolocation and this seems to already be a pattern: > device/nfc, device/vibration, device/vr... Renamed to just "interfaces" per rockot@ comment, and per usb/ example.
8 sources = [	8 sources = [

9 "init.mojom",	9 "geolocation.mojom",

10 ]	10 ]

11

12 use_new_wrapper_types = false

13 }	11 }

OLD	NEW

« device/geolocation/BUILD.gn ('K') | « device/geolocation/geolocation_service_impl.cc ('k') | device/geolocation/public/interfaces/OWNERS » ('j') | no next file with comments »