Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: third_party/WebKit/Source/core/input/EventHandler.cpp

Issue 2201853002: Blink handle selection handle visibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixing clear handles Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/EventHandler.cpp
diff --git a/third_party/WebKit/Source/core/input/EventHandler.cpp b/third_party/WebKit/Source/core/input/EventHandler.cpp
index 75d6b411101fce61600b66355c55b3ac5ae57eb1..7c8bcae844d331ffde2678d3648e865b910c9821 100644
--- a/third_party/WebKit/Source/core/input/EventHandler.cpp
+++ b/third_party/WebKit/Source/core/input/EventHandler.cpp
@@ -726,6 +726,9 @@ WebInputEventResult EventHandler::handleMouseMoveEvent(
const PlatformMouseEvent& event) {
TRACE_EVENT0("blink", "EventHandler::handleMouseMoveEvent");
+ if (!event.fromTouch())
+ m_frame->selection().clearHandles();
+
HitTestResult hoveredNode = HitTestResult();
WebInputEventResult result = handleMouseMoveOrLeaveEvent(event, &hoveredNode);
@@ -1951,6 +1954,7 @@ bool EventHandler::handleAccessKey(const WebKeyboardEvent& evt) {
WebInputEventResult EventHandler::keyEvent(
const WebKeyboardEvent& initialKeyEvent) {
+ m_frame->selection().clearHandles();
return m_keyboardEventManager->keyEvent(initialKeyEvent);
}

Powered by Google App Engine
This is Rietveld 408576698