Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Side by Side Diff: third_party/WebKit/Source/core/input/EventHandler.cpp

Issue 2201853002: Blink handle selection handle visibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixing clear handles Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org) 4 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
5 * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies) 5 * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies)
6 * 6 *
7 * Redistribution and use in source and binary forms, with or without 7 * Redistribution and use in source and binary forms, with or without
8 * modification, are permitted provided that the following conditions 8 * modification, are permitted provided that the following conditions
9 * are met: 9 * are met:
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 708 matching lines...) Expand 10 before | Expand all | Expand 10 after
719 m_frame->chromeClient().onMouseDown(result.innerNode()); 719 m_frame->chromeClient().onMouseDown(result.innerNode());
720 } 720 }
721 721
722 return eventResult; 722 return eventResult;
723 } 723 }
724 724
725 WebInputEventResult EventHandler::handleMouseMoveEvent( 725 WebInputEventResult EventHandler::handleMouseMoveEvent(
726 const PlatformMouseEvent& event) { 726 const PlatformMouseEvent& event) {
727 TRACE_EVENT0("blink", "EventHandler::handleMouseMoveEvent"); 727 TRACE_EVENT0("blink", "EventHandler::handleMouseMoveEvent");
728 728
729 if (!event.fromTouch())
730 m_frame->selection().clearHandles();
731
729 HitTestResult hoveredNode = HitTestResult(); 732 HitTestResult hoveredNode = HitTestResult();
730 WebInputEventResult result = handleMouseMoveOrLeaveEvent(event, &hoveredNode); 733 WebInputEventResult result = handleMouseMoveOrLeaveEvent(event, &hoveredNode);
731 734
732 Page* page = m_frame->page(); 735 Page* page = m_frame->page();
733 if (!page) 736 if (!page)
734 return result; 737 return result;
735 738
736 if (PaintLayer* layer = 739 if (PaintLayer* layer =
737 EventHandlingUtil::layerForNode(hoveredNode.innerNode())) { 740 EventHandlingUtil::layerForNode(hoveredNode.innerNode())) {
738 if (ScrollableArea* layerScrollableArea = 741 if (ScrollableArea* layerScrollableArea =
(...skipping 1205 matching lines...) Expand 10 before | Expand all | Expand 10 after
1944 m_activeIntervalTimer.stop(); 1947 m_activeIntervalTimer.stop();
1945 m_lastDeferredTapElement = nullptr; 1948 m_lastDeferredTapElement = nullptr;
1946 } 1949 }
1947 1950
1948 bool EventHandler::handleAccessKey(const WebKeyboardEvent& evt) { 1951 bool EventHandler::handleAccessKey(const WebKeyboardEvent& evt) {
1949 return m_keyboardEventManager->handleAccessKey(evt); 1952 return m_keyboardEventManager->handleAccessKey(evt);
1950 } 1953 }
1951 1954
1952 WebInputEventResult EventHandler::keyEvent( 1955 WebInputEventResult EventHandler::keyEvent(
1953 const WebKeyboardEvent& initialKeyEvent) { 1956 const WebKeyboardEvent& initialKeyEvent) {
1957 m_frame->selection().clearHandles();
1954 return m_keyboardEventManager->keyEvent(initialKeyEvent); 1958 return m_keyboardEventManager->keyEvent(initialKeyEvent);
1955 } 1959 }
1956 1960
1957 void EventHandler::defaultKeyboardEventHandler(KeyboardEvent* event) { 1961 void EventHandler::defaultKeyboardEventHandler(KeyboardEvent* event) {
1958 m_keyboardEventManager->defaultKeyboardEventHandler( 1962 m_keyboardEventManager->defaultKeyboardEventHandler(
1959 event, m_mouseEventManager->mousePressNode()); 1963 event, m_mouseEventManager->mousePressNode());
1960 } 1964 }
1961 1965
1962 void EventHandler::dragSourceEndedAt(const PlatformMouseEvent& event, 1966 void EventHandler::dragSourceEndedAt(const PlatformMouseEvent& event,
1963 DragOperation operation) { 1967 DragOperation operation) {
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
2080 } 2084 }
2081 2085
2082 FrameHost* EventHandler::frameHost() const { 2086 FrameHost* EventHandler::frameHost() const {
2083 if (!m_frame->page()) 2087 if (!m_frame->page())
2084 return nullptr; 2088 return nullptr;
2085 2089
2086 return &m_frame->page()->frameHost(); 2090 return &m_frame->page()->frameHost();
2087 } 2091 }
2088 2092
2089 } // namespace blink 2093 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698