third_party/WebKit/Source/core/editing/SelectionController.h - Issue 2201853002: Blink handle selection handle visibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/SelectionController.h

Issue 2201853002: Blink handle selection handle visibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed contextual search test function Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/SelectionController.h

diff --git a/third_party/WebKit/Source/core/editing/SelectionController.h b/third_party/WebKit/Source/core/editing/SelectionController.h

index 30eb0d352675a08b0fe5711f1933825c404828e1..8513fc1a2fb1001d2921d9c3d7664ec02a4065b6 100644

--- a/third_party/WebKit/Source/core/editing/SelectionController.h

+++ b/third_party/WebKit/Source/core/editing/SelectionController.h

@@ -98,7 +98,8 @@ class SelectionController final : public GarbageCollected<SelectionController> {

bool updateSelectionForMouseDownDispatchingSelectStart(

Node*,

const VisibleSelectionInFlatTree&,

- TextGranularity);

+ TextGranularity,

+ bool isHandleVisible = false);

yosin_UTC9 2016/10/17 07:27:46 Could you introduce |enum class| instead of using

amaralp 2016/10/19 04:26:38 Done.

FrameSelection& selection() const;