Chromium Code Reviews Chromium Code Reviews
Issue 2201853002:
Blink handle selection handle visibility (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright (C) 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved. | 2 * Copyright (C) 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved. |
| 3 * Copyright (C) 2015 Google Inc. All rights reserved. | 3 * Copyright (C) 2015 Google Inc. All rights reserved. |
| 4 * | 4 * |
| 5 * Redistribution and use in source and binary forms, with or without | 5 * Redistribution and use in source and binary forms, with or without |
| 6 * modification, are permitted provided that the following conditions | 6 * modification, are permitted provided that the following conditions |
| 7 * are met: | 7 * are met: |
| 8 * 1. Redistributions of source code must retain the above copyright | 8 * 1. Redistributions of source code must retain the above copyright |
| 9 * notice, this list of conditions and the following disclaimer. | 9 * notice, this list of conditions and the following disclaimer. |
| 10 * 2. Redistributions in binary form must reproduce the above copyright | 10 * 2. Redistributions in binary form must reproduce the above copyright |
| (...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 91 void selectClosestMisspellingFromHitTestResult(const HitTestResult&, | 91 void selectClosestMisspellingFromHitTestResult(const HitTestResult&, |
| 92 AppendTrailingWhitespace); | 92 AppendTrailingWhitespace); |
| 93 void selectClosestWordFromMouseEvent(const MouseEventWithHitTestResults&); | 93 void selectClosestWordFromMouseEvent(const MouseEventWithHitTestResults&); |
| 94 void selectClosestMisspellingFromMouseEvent( | 94 void selectClosestMisspellingFromMouseEvent( |
| 95 const MouseEventWithHitTestResults&); | 95 const MouseEventWithHitTestResults&); |
| 96 void selectClosestWordOrLinkFromMouseEvent( | 96 void selectClosestWordOrLinkFromMouseEvent( |
| 97 const MouseEventWithHitTestResults&); | 97 const MouseEventWithHitTestResults&); |
| 98 bool updateSelectionForMouseDownDispatchingSelectStart( | 98 bool updateSelectionForMouseDownDispatchingSelectStart( |
| 99 Node*, | 99 Node*, |
| 100 const VisibleSelectionInFlatTree&, | 100 const VisibleSelectionInFlatTree&, |
| 101 TextGranularity); | 101 TextGranularity, |
| 102 bool isHandleVisible = false); | |
|
yosin_UTC9
2016/10/17 07:27:46
Could you introduce |enum class| instead of using
amaralp
2016/10/19 04:26:38
Done.
| |
| 102 | 103 |
| 103 FrameSelection& selection() const; | 104 FrameSelection& selection() const; |
| 104 | 105 |
| 105 Member<LocalFrame> const m_frame; | 106 Member<LocalFrame> const m_frame; |
| 106 bool m_mouseDownMayStartSelect; | 107 bool m_mouseDownMayStartSelect; |
| 107 bool m_mouseDownWasSingleClickInSelection; | 108 bool m_mouseDownWasSingleClickInSelection; |
| 108 bool m_mouseDownAllowsMultiClick; | 109 bool m_mouseDownAllowsMultiClick; |
| 109 enum class SelectionState { | 110 enum class SelectionState { |
| 110 HaveNotStartedSelection, | 111 HaveNotStartedSelection, |
| 111 PlacedCaret, | 112 PlacedCaret, |
| 112 ExtendedSelection | 113 ExtendedSelection |
| 113 }; | 114 }; |
| 114 SelectionState m_selectionState; | 115 SelectionState m_selectionState; |
| 115 }; | 116 }; |
| 116 | 117 |
| 117 bool isLinkSelection(const MouseEventWithHitTestResults&); | 118 bool isLinkSelection(const MouseEventWithHitTestResults&); |
| 118 bool isExtendingSelection(const MouseEventWithHitTestResults&); | 119 bool isExtendingSelection(const MouseEventWithHitTestResults&); |
| 119 | 120 |
| 120 } // namespace blink | 121 } // namespace blink |
| 121 | 122 |
| 122 #endif // SelectionController_h | 123 #endif // SelectionController_h |
| OLD | NEW |
