Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: build/android/pylib/instrumentation/instrumentation_test_instance.py

Issue 2201833002: Added tombstones in instrumentation tests results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/instrumentation/instrumentation_test_instance.py
diff --git a/build/android/pylib/instrumentation/instrumentation_test_instance.py b/build/android/pylib/instrumentation/instrumentation_test_instance.py
index 62e62b8034a77649bb69cf741d092d57960f916f..d6a20ec7c01e5b61dd3f842141041537a42a1152 100644
--- a/build/android/pylib/instrumentation/instrumentation_test_instance.py
+++ b/build/android/pylib/instrumentation/instrumentation_test_instance.py
@@ -393,6 +393,9 @@ class InstrumentationTestInstance(test_instance.TestInstance):
self._coverage_directory = None
self._initializeTestCoverageAttributes(args)
+ self._tombstones = False
jbudorick 2016/08/01 17:39:18 Both the argument and the variable should have a s
BigBossZhiling 2016/08/01 22:35:12 Done.
+ self._initializeTombStonesAttributes(args)
+
def _initializeApkAttributes(self, args, error_func):
if args.apk_under_test:
apk_under_test_path = args.apk_under_test
@@ -535,6 +538,9 @@ class InstrumentationTestInstance(test_instance.TestInstance):
def _initializeTestCoverageAttributes(self, args):
self._coverage_directory = args.coverage_dir
+ def _initializeTombStonesAttributes(self, args):
jbudorick 2016/08/01 17:39:18 nit: Tombstones, not TombStones
BigBossZhiling 2016/08/01 22:35:12 Done.
+ self._tombstones = args.tombstones
+
@property
def additional_apks(self):
return self._additional_apks
@@ -607,6 +613,10 @@ class InstrumentationTestInstance(test_instance.TestInstance):
def timeout_scale(self):
return self._timeout_scale
+ @property
+ def tombstones(self):
+ return self._tombstones
+
#override
def TestType(self):
return 'instrumentation'
« no previous file with comments | « no previous file | build/android/pylib/instrumentation/test_result.py » ('j') | build/android/pylib/instrumentation/test_result.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698