Added tombstones in instrumentation tests results.

build/android/pylib/instrumentation/instrumentation_test_instance.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import collections
 import copy
 import logging
 import os
 import pickle
 import re
@@ skipping 375 matching lines @@
     self._driver_package = None
     self._driver_name = None
     self._initializeDriverAttributes()
 
     self._timeout_scale = None
     self._initializeTestControlAttributes(args)
 
     self._coverage_directory = None
     self._initializeTestCoverageAttributes(args)
 
+    self._tombstones = False

[jbudorick, 2016/08/01 17:39:18]

Both the argument and the variable should have a slightly different name. As is,
it's not clear that this is a flag -- instead, the name implies that this is
storing the tombstones.

[BigBossZhiling, 2016/08/01 22:35:12]

Done.

+    self._initializeTombStonesAttributes(args)
+
   def _initializeApkAttributes(self, args, error_func):
     if args.apk_under_test:
       apk_under_test_path = args.apk_under_test
       if not args.apk_under_test.endswith('.apk'):
         apk_under_test_path = os.path.join(
             constants.GetOutDirectory(), constants.SDK_BUILD_APKS_DIR,
             '%s.apk' % args.apk_under_test)
 
       if not os.path.exists(apk_under_test_path):
         error_func('Unable to find APK under test: %s' % apk_under_test_path)
@@ skipping 122 matching lines @@
     else:
       self._driver_apk = None
 
   def _initializeTestControlAttributes(self, args):
     self._screenshot_dir = args.screenshot_dir
     self._timeout_scale = args.timeout_scale or 1
 
   def _initializeTestCoverageAttributes(self, args):
     self._coverage_directory = args.coverage_dir
 
+  def _initializeTombStonesAttributes(self, args):

[jbudorick, 2016/08/01 17:39:18]

nit: Tombstones, not TombStones

[BigBossZhiling, 2016/08/01 22:35:12]

Done.

+    self._tombstones = args.tombstones
+
   @property
   def additional_apks(self):
     return self._additional_apks
 
   @property
   def apk_under_test(self):
     return self._apk_under_test
 
   @property
   def apk_under_test_incremental_install_script(self):
@@ skipping 52 matching lines @@
     return self._test_package
 
   @property
   def test_runner(self):
     return self._test_runner
 
   @property
   def timeout_scale(self):
     return self._timeout_scale
 
+  @property
+  def tombstones(self):
+    return self._tombstones
+
   #override
   def TestType(self):
     return 'instrumentation'
 
   #override
   def SetUp(self):
     if self._isolate_delegate:
       self._isolate_delegate.Remap(
           self._isolate_abs_path, self._isolated_abs_path)
       self._isolate_delegate.MoveOutputDeps()
@@ skipping 58 matching lines @@
   @staticmethod
   def GenerateTestResults(
       result_code, result_bundle, statuses, start_ms, duration_ms):
     return GenerateTestResults(result_code, result_bundle, statuses,
                                start_ms, duration_ms)
 
   #override
   def TearDown(self):
     if self._isolate_delegate:
       self._isolate_delegate.Clear()