Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2201823002: Make CallSite constructor inaccessible from JS (Closed)

Created:
4 years, 4 months ago by jgruber
Modified:
4 years, 4 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@get-stack-trace-line
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make CallSite constructor inaccessible from JS This type is not supposed to be constructable by users. Internally, we use CallSiteUtils::Construct to create CallSite objects; and we simply map a thrower builtin as the public CallSite constructor. R=yangguo@chromium.org BUG= Committed: https://crrev.com/8135caef32492b900f9d1d25276038d224b72ae1 Cr-Commit-Position: refs/heads/master@{#38234}

Patch Set 1 #

Patch Set 2 : Add tests #

Patch Set 3 : Remove builtin CallSite constructor #

Patch Set 4 : Fix Error.prepareStackTrace test #

Total comments: 2

Patch Set 5 : Revert "CHECK invalid arguments to CallSite constructor" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -54 lines) Patch
M src/bootstrapper.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/builtins/builtins.h View 1 2 2 chunks +1 line, -1 line 0 comments Download
M src/builtins/builtins-callsite.cc View 1 2 1 chunk +0 lines, -15 lines 0 comments Download
M src/builtins/builtins-internal.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/execution.cc View 1 2 1 chunk +2 lines, -5 lines 0 comments Download
M src/messages.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/messages.cc View 1 2 3 4 5 chunks +14 lines, -23 lines 0 comments Download
M test/mjsunit/stack-traces.js View 1 2 3 2 chunks +22 lines, -7 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
jgruber
The kind of exception we throw is up for debate. I went with kUnsupported and ...
4 years, 4 months ago (2016-08-01 15:09:10 UTC) #3
jgruber
https://codereview.chromium.org/2201823002/diff/60001/test/mjsunit/stack-traces.js File test/mjsunit/stack-traces.js (right): https://codereview.chromium.org/2201823002/diff/60001/test/mjsunit/stack-traces.js#newcode404 test/mjsunit/stack-traces.js:404: Error.stackTraceLimit = oldStackTraceLimit; Note: This fixes a few followup ...
4 years, 4 months ago (2016-08-02 08:21:48 UTC) #10
Yang
lgtm.
4 years, 4 months ago (2016-08-02 09:02:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2201823002/80001
4 years, 4 months ago (2016-08-02 09:06:57 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-08-02 09:29:23 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 09:33:51 UTC) #19
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/8135caef32492b900f9d1d25276038d224b72ae1
Cr-Commit-Position: refs/heads/master@{#38234}

Powered by Google App Engine
This is Rietveld 408576698