Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Unified Diff: src/execution.cc

Issue 2201823002: Make CallSite constructor inaccessible from JS (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@get-stack-trace-line
Patch Set: Revert "CHECK invalid arguments to CallSite constructor" Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/builtins-internal.cc ('k') | src/messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/execution.cc
diff --git a/src/execution.cc b/src/execution.cc
index 48b92ffd2856b6b593924a928c64d74dcd6ad2de..4ec18f87353255809d8545ec8ecee22e7e60dc2a 100644
--- a/src/execution.cc
+++ b/src/execution.cc
@@ -431,13 +431,10 @@ Handle<String> Execution::GetStackTraceLine(Handle<Object> recv,
Handle<Object> pos,
Handle<Object> is_global) {
Isolate* isolate = fun->GetIsolate();
-
- Handle<JSFunction> ctor =
- handle(isolate->native_context()->callsite_function(), isolate);
Handle<Object> strict_mode = isolate->factory()->ToBoolean(false);
- MaybeHandle<Object> maybe_callsite = CallSiteUtils::Construct(
- isolate, ctor, ctor, recv, fun, pos, strict_mode);
+ MaybeHandle<Object> maybe_callsite =
+ CallSiteUtils::Construct(isolate, recv, fun, pos, strict_mode);
if (maybe_callsite.is_null()) {
isolate->clear_pending_exception();
return isolate->factory()->empty_string();
« no previous file with comments | « src/builtins/builtins-internal.cc ('k') | src/messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698