third_party/WebKit/Source/core/workers/WorkerThread.h - Issue 2201623002: [DevTools] Move WorkerInspectorController to WorkerThread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/WorkerThread.h

Issue 2201623002: [DevTools] Move WorkerInspectorController to WorkerThread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@can-execute-scripts

Patch Set: rebased Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp ('k') | third_party/WebKit/Source/core/workers/WorkerThread.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/WorkerThread.h

diff --git a/third_party/WebKit/Source/core/workers/WorkerThread.h b/third_party/WebKit/Source/core/workers/WorkerThread.h

index cf23ac89b4d94323be938a80b8ced3ee2ba9136d..ffdf714a290a674d479fbd2934268c9d1eebd683 100644

--- a/third_party/WebKit/Source/core/workers/WorkerThread.h

+++ b/third_party/WebKit/Source/core/workers/WorkerThread.h

@@ -135,9 +135,10 @@ public:

void startRunningDebuggerTasksOnPauseOnWorkerThread();

void stopRunningDebuggerTasksOnPauseOnWorkerThread();

- // Can be called only on the worker thread, WorkerOrWorkletGlobalScope is

- // not thread safe.

+ // Can be called only on the worker thread, WorkerOrWorkletGlobalScope

+ // and WorkerInspectorController are not thread safe.

WorkerOrWorkletGlobalScope* globalScope();

+ WorkerInspectorController* workerInspectorController();

// Called for creating WorkerThreadLifecycleObserver on both the main thread

// and the worker thread.

@@ -238,6 +239,7 @@ private:

Mutex m_threadStateMutex;

Persistent<WorkerOrWorkletGlobalScope> m_globalScope;

+ Persistent<WorkerInspectorController> m_workerInspectorController;

// Signaled when the thread starts termination on the main thread.

std::unique_ptr<WaitableEvent> m_terminationEvent;