blimp/client/core/contents/blimp_contents_impl_unittest.cc - Issue 2201433002: Migrate TabControlFeature from 0.5 to 0.6

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/contents/blimp_contents_impl_unittest.cc

Issue 2201433002: Migrate TabControlFeature from 0.5 to 0.6 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove BlmipContentImpl default constructor, Move BlimpContentsDeletionObserver declaration to blim… Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/core/contents/blimp_contents_impl_unittest.cc

diff --git a/blimp/client/core/contents/blimp_contents_impl_unittest.cc b/blimp/client/core/contents/blimp_contents_impl_unittest.cc

index 03132529690813afa33bd0e4797b8de48480e449..a7c80a2cf205676424b545d75de389da0e6cc3c0 100644

--- a/blimp/client/core/contents/blimp_contents_impl_unittest.cc

+++ b/blimp/client/core/contents/blimp_contents_impl_unittest.cc

@@ -15,6 +15,7 @@ namespace {

const GURL kExampleURL = GURL("https://www.example.com/");

const GURL kOtherExampleURL = GURL("https://www.otherexample.com/");

+const int kDummyTabId = 0;

class TestBlimpContentsObserver : public BlimpContentsObserver {

public:

@@ -33,7 +34,7 @@ class TestBlimpContentsObserver : public BlimpContentsObserver {

TEST(BlimpContentsImplTest, Basic) {

base::MessageLoop loop;

- BlimpContentsImpl blimp_contents;

+ BlimpContentsImpl blimp_contents{kDummyTabId};

BlimpNavigationController& navigation_controller =

blimp_contents.GetNavigationController();