blimp/client/core/contents/blimp_contents_impl.cc - Issue 2201433002: Migrate TabControlFeature from 0.5 to 0.6

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/contents/blimp_contents_impl.cc

Issue 2201433002: Migrate TabControlFeature from 0.5 to 0.6 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove BlmipContentImpl default constructor, Move BlimpContentsDeletionObserver declaration to blim… Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/core/contents/blimp_contents_impl.cc

diff --git a/blimp/client/core/contents/blimp_contents_impl.cc b/blimp/client/core/contents/blimp_contents_impl.cc

index 37d25a9ad5d172435c2ef24eba5a15cf65596921..9fdd73d1e3c5e1e72df5ba9d2aa5bc37d7233f51 100644

--- a/blimp/client/core/contents/blimp_contents_impl.cc

+++ b/blimp/client/core/contents/blimp_contents_impl.cc

@@ -22,9 +22,12 @@ const char kBlimpContentsImplAndroidKey[] = "blimp_contents_impl_android";

#endif // OS_ANDROID

}

-BlimpContentsImpl::BlimpContentsImpl() : navigation_controller_(this) {}

+BlimpContentsImpl::BlimpContentsImpl(int id)

+ : navigation_controller_(this), id_(id) {}

-BlimpContentsImpl::~BlimpContentsImpl() {}

+BlimpContentsImpl::~BlimpContentsImpl() {

+ FOR_EACH_OBSERVER(BlimpContentsObserver, observers_, OnContentsDestroyed());

#if defined(OS_ANDROID)