Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2201413002: Show 3 rows in the account chooser. (Closed)

Created:
4 years, 4 months ago by vasilii
Modified:
4 years, 4 months ago
Reviewers:
melandory
CC:
chromium-reviews, tfarina, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show 3 rows in the account chooser. They appear in case the credential has all three fields: - username - display name - federation provider BUG=633994 Committed: https://crrev.com/8c75da0d1db3c9d2d590bf3788b246fa45ed4809 Cr-Commit-Position: refs/heads/master@{#409739}

Patch Set 1 #

Patch Set 2 : Update a unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -11 lines) Patch
M chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm View 1 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_view_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_view_utils.cc View 1 chunk +14 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/passwords/credentials_item_view.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
vasilii
Hi Tanya, please review. The actual screenshots are attached to the bug.
4 years, 4 months ago (2016-08-03 15:17:01 UTC) #5
melandory
On 2016/08/03 15:17:01, vasilii wrote: > Hi Tanya, > > please review. The actual screenshots ...
4 years, 4 months ago (2016-08-04 07:48:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2201413002/20001
4 years, 4 months ago (2016-08-04 08:19:51 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-04 08:23:50 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 08:25:14 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8c75da0d1db3c9d2d590bf3788b246fa45ed4809
Cr-Commit-Position: refs/heads/master@{#409739}

Powered by Google App Engine
This is Rietveld 408576698