Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4494)

Unified Diff: chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm

Issue 2201413002: Show 3 rows in the account chooser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update a unit test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/passwords/manage_passwords_view_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm b/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm
index 80419d5ed86430e5de266e1a49fe2d27e01d240f..e368440e182913f6242212161c8a97ae2e6f9eaa 100644
--- a/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm
@@ -145,8 +145,10 @@ TEST_F(AccountChooserViewControllerTest, ConfiguresViews) {
TEST_F(AccountChooserViewControllerTest, ConfiguresFederatedCredential) {
const char federation[] = "https://google.com/idp";
const char name[] = "Peter the Great";
+ const char username[] = "pete";
+
PasswordDialogController::FormsVector local_forms;
- local_forms.push_back(Credential("pizza"));
+ local_forms.push_back(Credential(username));
local_forms.back()->federation_origin = url::Origin(GURL(federation));
local_forms.back()->display_name = base::ASCIIToUTF16(name);
SetUpAccountChooser(&local_forms);
@@ -158,6 +160,7 @@ TEST_F(AccountChooserViewControllerTest, ConfiguresFederatedCredential) {
base::SysNSStringToUTF8([base::mac::ObjCCastStrict<CredentialItemButton>(
[buttons objectAtIndex:0]) title]);
EXPECT_THAT(title, testing::HasSubstr(name));
+ EXPECT_THAT(title, testing::HasSubstr(username));
EXPECT_THAT(title, testing::HasSubstr(GURL(federation).host()));
}
« no previous file with comments | « no previous file | chrome/browser/ui/passwords/manage_passwords_view_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698