Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2201363004: Use explicit pool to define concurrent_links jobs. (Closed)

Created:
4 years, 4 months ago by sdefresne
Modified:
4 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use explicit pool to define concurrent_links jobs. Define an explicit pool //build/toolchain:link_pool with a depth of concurrent_links and convert all the toolchain link targets to use it instead of setting concurrent_links property of the tool. BUG=612786 Committed: https://crrev.com/96e7407d139b8a8e43f6db7d4af3118078aba7de Cr-Commit-Position: refs/heads/master@{#409846}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -17 lines) Patch
A + build/toolchain/BUILD.gn View 1 chunk +5 lines, -3 lines 1 comment Download
M build/toolchain/gcc_toolchain.gni View 5 chunks +3 lines, -3 lines 0 comments Download
M build/toolchain/mac/BUILD.gn View 4 chunks +3 lines, -2 lines 0 comments Download
M build/toolchain/win/BUILD.gn View 8 chunks +3 lines, -9 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
sdefresne
https://codereview.chromium.org/2201363004/diff/1/build/toolchain/BUILD.gn File build/toolchain/BUILD.gn (right): https://codereview.chromium.org/2201363004/diff/1/build/toolchain/BUILD.gn#newcode7 build/toolchain/BUILD.gn:7: if (current_toolchain == default_toolchain) { Note: this is a ...
4 years, 4 months ago (2016-08-03 21:31:50 UTC) #3
sdefresne
Please take a look.
4 years, 4 months ago (2016-08-03 21:34:15 UTC) #5
brettw
lgtm
4 years, 4 months ago (2016-08-04 18:24:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2201363004/1
4 years, 4 months ago (2016-08-04 18:31:10 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 18:41:32 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 18:44:50 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96e7407d139b8a8e43f6db7d4af3118078aba7de
Cr-Commit-Position: refs/heads/master@{#409846}

Powered by Google App Engine
This is Rietveld 408576698