Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 220123005: Revert of Re-landing r170008, removing prefixed Shadow DOM APIs in Element. (Closed)

Created:
6 years, 8 months ago by tkent
Modified:
6 years, 8 months ago
Reviewers:
esprehn, hayato, dglazkov
CC:
blink-reviews, caseq+blink_chromium.org, sof, loislo+blink_chromium.org, eustas+blink_chromium.org, rwlbuis, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, arv+blink, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com, adamk+blink_chromium.org
Visibility:
Public.

Description

Revert of Re-landing r170008, removing prefixed Shadow DOM APIs in Element. (https://codereview.chromium.org/218943003/) Reason for revert: Broke OpenAudioFiles/FileManagerBrowserTest again. http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/22744 Original issue's description: > Re-landing r170008, removing prefixed Shadow DOM APIs in Element. > > The previous attempt, https://codereview.chromium.org/208503004, was reverted in https://codereview.chromium.org/212303005/. > The reason of reverting is that there is a JavaScript code uses prefixed Shadow DOM API in the chromium side. > I've fixed that in https://codereview.chromium.org/214093002/. > > Let me re-land r170008. I hope it won't break anything this time. > > BUG=242153 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170460 TBR=dglazkov@chromium.org,esprehn@chromium.org,hayato@chromium.org NOTREECHECKS=true NOTRY=true BUG=242153 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170519

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -25 lines) Patch
M LayoutTests/css3/viewport-percentage-lengths/viewport-percentage-lengths-resize.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/HTMLDialogElement/modal-dialog-distributed-child-is-not-inert.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/gc-treescope.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/reattach-content-ancestor.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/reinsert-insertion-point.html View 2 chunks +2 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/shadowdom-for-input-spellcheck.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/stale-distribution-after-shadow-removal.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/layers/crash-shadowdom-scrollbar-no-scrollable-area.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector-enabled/shadow-dom-rules.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector-enabled/shadow-dom-rules-restart.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector-protocol/shadow-dom-rules-in-styleSheetAddedEvent.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/breadcrumb-shadow-roots.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/shadow-dom-rules.html View 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/Events/EventsDispatchingInDeeplyNestedShadowTrees.html View 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/Events/EventsDispatchingInShadowTrees.html View 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/ShadowDOM/ChangingClassNameShadowDOM.html View 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/ShadowDOM/ChangingSelect.html View 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/ShadowDOM/ContentReprojection.html View 1 chunk +2 lines, -2 lines 0 comments Download
M PerformanceTests/ShadowDOM/DistributionWithMultipleShadowRoots.html View 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/ShadowDOM/LargeDistributionWithoutLayout.html View 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/ShadowDOM/MultipleInsertionPoints.html View 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/ShadowDOM/ShadowReprojection.html View 1 chunk +2 lines, -2 lines 0 comments Download
M PerformanceTests/ShadowDOM/SmallDistributionWithLayout.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tkent
Created Revert of Re-landing r170008, removing prefixed Shadow DOM APIs in Element.
6 years, 8 months ago (2014-04-01 06:50:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/220123005/1
6 years, 8 months ago (2014-04-01 06:50:34 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 06:51:06 UTC) #3
Message was sent while issue was closed.
Change committed as 170519

Powered by Google App Engine
This is Rietveld 408576698