Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 208503004: Remove prefixed Shadow DOM APIs in Element. (Closed)

Created:
6 years, 9 months ago by hayato
Modified:
6 years, 9 months ago
Reviewers:
esprehn, dglazkov
CC:
blink-reviews, caseq+blink_chromium.org, sof, loislo+blink_chromium.org, eustas+blink_chromium.org, rwlbuis, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, arv+blink, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com, adamk+blink_chromium.org
Visibility:
Public.

Description

Remove prefixed Shadow DOM APIs in Element. It's time to remove. We've shipped unprefixed APIs for these APIs. BUG=336121 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170008

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -33 lines) Patch
M LayoutTests/css3/viewport-percentage-lengths/viewport-percentage-lengths-resize.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/HTMLDialogElement/modal-dialog-distributed-child-is-not-inert.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/gc-treescope.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/reattach-content-ancestor.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/reinsert-insertion-point.html View 2 chunks +1 line, -2 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadowdom-for-input-spellcheck.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/stale-distribution-after-shadow-removal.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/layers/crash-shadowdom-scrollbar-no-scrollable-area.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector-enabled/shadow-dom-rules.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector-enabled/shadow-dom-rules-restart.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector-protocol/shadow-dom-rules-in-styleSheetAddedEvent.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/breadcrumb-shadow-roots.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/shadow-dom-rules.html View 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/Events/EventsDispatchingInDeeplyNestedShadowTrees.html View 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/Events/EventsDispatchingInShadowTrees.html View 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/ShadowDOM/ChangingClassNameShadowDOM.html View 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/ShadowDOM/ChangingSelect.html View 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/ShadowDOM/ContentReprojection.html View 1 chunk +2 lines, -2 lines 0 comments Download
M PerformanceTests/ShadowDOM/DistributionWithMultipleShadowRoots.html View 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/ShadowDOM/LargeDistributionWithoutLayout.html View 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/ShadowDOM/MultipleInsertionPoints.html View 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/ShadowDOM/ShadowReprojection.html View 1 chunk +2 lines, -2 lines 0 comments Download
M PerformanceTests/ShadowDOM/SmallDistributionWithLayout.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
hayato
PTAL
6 years, 9 months ago (2014-03-25 08:31:57 UTC) #1
dglazkov
lgtm
6 years, 9 months ago (2014-03-25 15:53:54 UTC) #2
hayato
The CQ bit was checked by hayato@chromium.org
6 years, 9 months ago (2014-03-26 02:56:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/208503004/1
6 years, 9 months ago (2014-03-26 02:56:34 UTC) #4
commit-bot: I haz the power
Change committed as 170008
6 years, 9 months ago (2014-03-26 03:47:34 UTC) #5
tkent
Will this CL break existing library like Polymer? Did you post "Intent to remove" mail ...
6 years, 9 months ago (2014-03-26 09:01:48 UTC) #6
vsevik
A revert of this CL has been created in https://codereview.chromium.org/212303005/ by vsevik@chromium.org. The reason for ...
6 years, 9 months ago (2014-03-26 09:23:33 UTC) #7
hayato
On 2014/03/26 09:23:33, vsevik wrote: > A revert of this CL has been created in ...
6 years, 9 months ago (2014-03-27 04:06:19 UTC) #8
hayato
6 years, 9 months ago (2014-03-27 04:08:37 UTC) #9
Message was sent while issue was closed.
On 2014/03/26 09:01:48, tkent wrote:
> Will this CL break existing library like Polymer?
> Did you post "Intent to remove" mail to blink-dev?

We assumed that we've already announced that in "intent to ship Shadow DOM'
thread.

> We will simultaneously unship the prefixed implementation of Shadow DOM.

I think Polymer team knows this well.

Powered by Google App Engine
This is Rietveld 408576698