Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: Source/core/css/invalidation/StyleInvalidator.cpp

Issue 220123004: Add support for element ids in TargetedStyleRecalc (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix comment. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/invalidation/StyleInvalidator.cpp
diff --git a/Source/core/css/invalidation/StyleInvalidator.cpp b/Source/core/css/invalidation/StyleInvalidator.cpp
index cd53db244ef75f468a674bab7496a822d8228e87..8b659bbcba7c80e024016c374eb445b5eeafbe97 100644
--- a/Source/core/css/invalidation/StyleInvalidator.cpp
+++ b/Source/core/css/invalidation/StyleInvalidator.cpp
@@ -59,6 +59,7 @@ void StyleInvalidator::RecursionData::pushInvalidationSet(const DescendantInvali
{
invalidationSet.getClasses(m_invalidationClasses);
invalidationSet.getAttributes(m_invalidationAttributes);
+ invalidationSet.getIds(m_invalidationIds);
m_foundInvalidationSet = true;
}
@@ -77,7 +78,13 @@ bool StyleInvalidator::RecursionData::matchesCurrentInvalidationSets(Element& el
return true;
}
}
-
+ if (element.hasID()) {
+ const AtomicString& id = element.idForStyleResolution();
+ for (Vector<AtomicString>::const_iterator it = m_invalidationIds.begin(); it != m_invalidationIds.end(); ++it) {
+ if (id == *it)
esprehn 2014/04/01 23:11:19 You don't need this loop, if (m_invalidationIds.c
chrishtr 2014/04/01 23:20:08 Good point! Fixed.
+ return true;
+ }
+ }
return false;
}

Powered by Google App Engine
This is Rietveld 408576698